[miniflare] Start runtime disposal before browser/proxy cleanup - #15143
Merged
petebacondarwin merged 4 commits intoAug 15, 2026
Merged
petebacondarwin merged 4 commits into
petebacondarwin merged 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 2dc853e The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
petebacondarwin
and removed request for
a team
August 12, 2026 02:01
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
2 tasks done
petebacondarwin
force-pushed
the
source/miniflare-runtime-settlement-clean
branch
from
August 14, 2026 16:13
1277272 to
63fc4a8
Compare
petebacondarwin
approved these changes
Aug 15, 2026
workers-devprod
approved these changes
Aug 15, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15085.
Miniflare.dispose()currently waits for browser/proxy cleanup before callingRuntime.dispose(), so either cleanup can delay or skip theworkerdtermination request.This starts
Runtime.dispose()first, which requestsworkerdtermination before those cleanup awaits. Browser cleanup → exit-hook removal → proxy cleanup keeps the same order.If browser/proxy cleanup fails,
Miniflare.dispose()remembers that error, waits for the already-started runtime exit, continues the remaining cleanup, then returns the cleanup error.Tests cover:
workerdtermination while proxy cleanup is still pending;Miniflare.dispose()pending on a proxy cleanup failure until the runtime exit settles.Tests
Public documentation
A picture of a long-eared jerboa
