Repository navigation
[wrangler] fix: normalize CRLF before sending D1 commands to the remote query API - #15044
Merged
petebacondarwin merged 3 commits intoAug 15, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 1b7cd77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
emily-shen
and removed request for
a team
August 5, 2026 17:08
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
petebacondarwin
requested changes
Aug 11, 2026
petebacondarwin
marked this pull request as draft
August 11, 2026 20:19
stareezy-1
marked this pull request as ready for review
August 12, 2026 07:33
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
Author
|
CI status: I audited all 22 failing checks. They are unrelated to the D1 change: the failing jobs generate compatibility date The same repository-wide failure is affecting Cloudflare-authored PR #15143 and matches #14942. The focused D1 tests and |
petebacondarwin
force-pushed
the
fix/14991-d1-crlf-migrations
branch
from
August 14, 2026 10:05
5cef407 to
3bfce39
Compare
The D1 query API splits multi-statement SQL on ';' server-side and mishandles CRLF line endings inside compound statements such as a CREATE TRIGGER ... BEGIN ... END; body, producing 'incomplete input: SQLITE_ERROR'. wrangler d1 migrations apply --remote sends the whole migration (plus the tracking INSERT) as one command string, so CRLF migrations with triggers failed while the same bytes via the import-based execute --remote --file succeeded. Normalize CRLF to LF in the command path before sending. Closes cloudflare#14991.
- Remove the conventional-commit prefix from the changeset title (REVIEW.md forbids type prefixes in changeset titles). - Re-indent the new execute test to the describe nesting level and apply oxfmt so the repository formatting check passes.
petebacondarwin
force-pushed
the
fix/14991-d1-crlf-migrations
branch
from
August 14, 2026 12:30
3bfce39 to
1b7cd77
Compare
petebacondarwin
approved these changes
Aug 14, 2026
petebacondarwin
approved these changes
Aug 15, 2026
petebacondarwin
left a comment
petebacondarwin
left a comment
Contributor
There was a problem hiding this comment.
Codeowners bypass
petebacondarwin
enabled auto-merge (squash)
August 15, 2026 11:13
workers-devprod
approved these changes
Aug 15, 2026
workers-devprod
left a comment
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14991
wrangler d1 migrations apply --remotefailed withincomplete input: SQLITE_ERROR [7500]whenever a migration file had CRLF line endings and contained aCREATE TRIGGER ... BEGIN ... END;body — the default situation for Windows checkouts withcore.autocrlf=true.Root cause:
migrations apply --remotesends the whole migration (plus the trackingINSERT) as onesqlstring to the D1/queryendpoint, which splits multi-statement SQL on;server-side and mishandles structural CRLF inside compound statement bodies. The identical bytes succeed viaexecute --remote --filebecause that path uses the D1 import API; the client-side splitter is not involved in the command path.Fix: normalize only structural CRLF before sending commands to the remote query API. The SQL-aware normalizer preserves CRLF inside single-, double-, backtick-, and bracket-quoted content, including doubled quote escapes, so remote execution does not silently change stored values.
Verification: all 16 D1 splitter tests, 16 D1 execute tests, and 33 D1 migration tests pass. The repository-wide
pnpm checkalso passes.Note
This is a contribution from an AI agent: stareezy-1.