[vitest-plugin] Rename package for v1 - #15074
Conversation
🦋 Changeset detectedLatest commit: ca667fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
UnknownError: ProviderInitError |
|
@penalosa Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
|
✅ All changesets look good |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
80b5da1 to
5696452
Compare
5696452 to
140cb9f
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
|
I've addressed the review findings from Devin Review: Fixed issues:
Additional fix (not flagged but would break the release):
I verified the codemod output and changeset package-name validity locally. |
|
I've addressed all the review findings for PR #15074. Here's a summary of the changes: Changes made
Additional fix (not flagged but release-breaking)Four existing changesets referenced Note: I could not run the full test suite ( |
7dfdbfc to
ee17c7e
Compare
Rename `@cloudflare/vitest-pool-workers` to `@cloudflare/vitest-plugin` — the package is a Vite/Vitest plugin (`cloudflareTest()` in `plugins: []`), not a custom Vitest pool, so the old name no longer describes what it is. - Move `packages/vitest-pool-workers` to `packages/vitest-plugin`, and the `vitest-pool-workers-examples` / `vitest-pool-workers-remote-bindings` fixtures to `vitest-plugin-examples` / `vitest-plugin-remote-bindings` - Repoint the `workspace:*` consumers (`edge-preview-authenticated-proxy` and the `browser-run`, `worker-with-unsafe-external-plugin` and `workers-shared-asset-config` fixtures) - Allow the one-off major bump in `validate-changesets.ts` - Update `WORKER_NAME_PREFIX` to `vitest-plugin-`, and the matching `vitest-plugin-runner-` check in Miniflare's `fallbackWorkerName` — these must stay in sync or the assets + Vitest fallback Worker misroutes Migration is handled by `npx @cloudflare/codemods vitest:pool-workers-to-vitest-plugin`. The packages that consume the *published* package rather than the workspace one stay on the old name until v1 is on npm — the four `catalog:default` consumers (`pages-shared`, `workers-shared`, `workflows-shared`, `kv-asset-handler`) and the C3 `hello-world` templates. Both need repointing as a release follow-up.
ee17c7e to
1b9b5c3
Compare
dario-piotrowicz
left a comment
There was a problem hiding this comment.
I think you might have missed a few places such as:
Or are these intentionally left as such?
These are intentionally left because they rely on the published package (to avoid circular deps). I'll update these in a followup once published |
oh, alright, thanks! 😄 |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
This PR is stacked on #13830 and should merge after it.
Renames
@cloudflare/vitest-pool-workersto@cloudflare/vitest-pluginfor the v1 release. This updates workspace consumers, fixtures, package metadata, CI configuration, and documentation, and includes a codemod and migration changeset for existing users.A picture of a cute animal (not mandatory, but encouraged)