Skip to content

Fix workers-sdk Vitest fixture filter - #7077

Merged
apeacock1991 merged 1 commit into
mainfrom
apeacock/fix-workers-sdk-vitest-filter
Aug 20, 2026
Merged

apeacock1991 merged 1 commit into
mainfrom
apeacock/fix-workers-sdk-vitest-filter

Conversation

@apeacock1991

Copy link
Copy Markdown
Contributor

Summary

Update the workers-sdk Vitest fixture filter after the fixture workspace was renamed in cloudflare/workers-sdk#15074. The workers-sdk integration job checks out the moving default branch, where the old path no longer exists.

Testing

Verified on workers-sdk main that fixtures/vitest-plugin-examples exists and exposes the test:ci script, while the old fixture path no longer exists.

workers-sdk renamed the Vitest fixture workspace. Update the integration job to select its new path.
@apeacock1991
apeacock1991 requested review from a team as code owners August 20, 2026 09:03
@ask-bonk

ask-bonk Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@codspeed

codspeed Bot commented Aug 20, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.07%

❌ 1 regressed benchmark
✅ 71 untouched benchmarks
⏩ 129 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ Encode_ASCII_256[TextEncoder][0/0/256] 2.9 ms 3.2 ms -12.07%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing apeacock/fix-workers-sdk-vitest-filter (189db4b) with main (dea490e)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@apeacock1991
apeacock1991 enabled auto-merge August 20, 2026 09:30
@apeacock1991
apeacock1991 merged commit 2778315 into main Aug 20, 2026
25 checks passed
@apeacock1991
apeacock1991 deleted the apeacock/fix-workers-sdk-vitest-filter branch August 20, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants