Repository navigation
Support external PostgreSQL for NetBox and Keycloak - #1290
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the existing external PostgreSQL configuration work consistently for NetBox and embedded Keycloak. The application connection settings already accept an external host, but Keycloak readiness queries the maintenance database, NetBox backups run in the embedded PostgreSQL container, and restore SQL defaults to the username's database rather than the configured database.
Closes #632.
Changes
postgresmaintenance database. Preserve JDBC URL properties for verified TLS and bracket IPv6 hosts.PGSSLMODEin NetBox unlessDB_SSLMODEexplicitly overrides it. Apply that same override during backup and restore.ON_ERROR_STOP.Validation
verify-fullTLS, rejection of an incorrect hostname and untrusted CA, actual NetBox configuration connectivity, realpg_dump, and a real restore throughnetbox_init.execute_restore_commandsusing a custom database name.Limits
Configuration uses the existing environment files; this does not add installer menus or provision an external database automatically. The full Malcolm stack and full NetBox web service were not started. NetBox verification loaded its actual configuration and connected with psycopg. No managed cloud database provider was tested.
The built-in NetBox restore drops and recreates its selected database and still requires ownership,
CREATEDBand maintenance-database access. Restricted managed-service roles require an administrator/provider restore instead. Kubernetes command routing is unit-tested; a Kubernetes cluster was not provisioned. Existing limitations on Kubernetes media backup remain unchanged.The temporary database, Keycloak container, isolated network, certificate volume and test credentials were removed after validation.