Repository navigation
Preserve saved installer configuration during bulk environment import - #1222
sylvesterkaczmarek wants to merge 114 commits into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
…tel-timezone-timestamps-20261006 Preserve threat-intelligence timestamps across host timezones
…t-pattern-boolean-semantics-20261006 Reject STIX conjunctions and partial non-equality patterns
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
…fest-cutoff-times-20261006 Apply UTC cutoffs and the supplied fallback time to MISP manifests
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
…p-without-health-wait-20261006 Keep PCAP duplicate checks enabled when startup health waiting is disabled
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
…worker-cancellation-20261006 Cancel waiting scan workers without releasing unowned capacity
…ention-overlapping-patterns-20261006 Count overlapping index selections once during retention pruning
…-timezone-invariance-20261006 Preserve UTC query instants across API host timezones
…ral-node-matching-20261006 Match literal sensor names when checking PCAP duplicates
…ock-inode-lifetime-20261006 Keep cleanup runners coordinated through a stable lock file
…single-record-registry-20261006 Accept single-record Filebeat registries during cleanup
…-candidate-byte-precision-20261007 Preserve fractional index sizes when choosing retention deletions
…positive-upload-chunks-20261007 Reject nonpositive file-upload chunk sizes before reading data
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
3.1.59 is affected by GHSA-239g-whfq-7xj9, GHSA-g5vv-9gxw-82hx and GHSA-rw58-wc66-99g4; 3.1.62 also clears GHSA-59cr-6r3x-644w, the last open GitPython advisory in OSV.
Retain the original per-file exception containment, record candidate files, discovered names and PLUGINS changes, and format with Black. Add logging and unexpected-parser-error regression coverage. Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
…x-plugin-discovery-20261015 Make NetBox plugin discovery deterministic and scoped
55959a8 to
bb58e5d
Compare
|
Thanks for this, @sylvesterkaczmarek. I spent some time testing it, and it does what it says. Your Hedgehog regression test fails on the current code and passes with the patch, and a round-trip through the While digging in, I found that the same underlying problem shows up in a few places outside That change reaches into parts of the installer with a lot of history behind them, so I'm going to take it on myself for the next release (v26.11.0). You don't need to rework this PR to cover the broader approach. I'll keep it open for now as a reference, and I expect some from this will carry over into the final fix. Thanks again. |
|
Thanks for testing the Hedgehog round trip and tracing the remaining load paths. Agreed that tracking which settings were explicitly supplied needs to work consistently across |
af68573 to
c6160d8
Compare
Value rules now declare a kind (derived, cascade, invariant) and are paused while configuration loads, then refreshed once. Loaded values are protected from cascades like values set in the session. Sources have fixed precedence: command line, settings file, its raw .env backup, existing .env files, compose file, ISO preseed. Saving is staged and all-or-nothing, and invalid loaded values block the save. Also fixes: blank Zeek intel cron lost on export/import, suggested memory sizes not loading, generated .env files missing a final newline, and the broken get_env_var_by_item_key wrapper. ref: cisagov#949 cisagov#1110 cisagov#1222 also, update installer tests that expected behavior the code doesn't have The Traefik tests exposed OpenSearch while open ports was still "No", which turns exposure back off; they now choose "Customize" first. The storage directory tests expected blank directories to be flagged when default locations are off, but a blank directory uses its default location, so they now test that, and a new compose integration test checks the fallback. Signed-off-by: Seth Grover <seth.d.grover@gmail.com>
|
closing in lieu of #1300 |
Addresses #949.
Changes
Validation
A live Hedgehog deployment was not available for integration testing.
Integration refresh (15 October 2026)
contributor-prsata1da19b0, not the oldermainsnapshot. Local dry-run integration of all 21 reviewed open PRs completed without merge conflicts.python -m pytest -q shared/tests/test_env_file_import_existing.py.