Skip to content

feat: validate parameters before loop - #8

Merged
chaspy merged 7 commits into
chaspy:mainfrom
suzuki-shunsuke:fix/validate-params-before-loop
Jan 31, 2021
Merged

chaspy merged 7 commits into
chaspy:mainfrom
suzuki-shunsuke:fix/validate-params-before-loop

Conversation

@suzuki-shunsuke

@suzuki-shunsuke suzuki-shunsuke commented Jan 28, 2021 •

Copy link
Copy Markdown
Contributor

This includes #6 .

The exporter doesn't have to do some process in every loop.
The exporter should parse and validate input parameters only at once before loop.
If the input parameter is invalid, the exporter should return error immediately.

@suzuki-shunsuke
suzuki-shunsuke marked this pull request as ready for review January 28, 2021 12:46
@chaspy
chaspy self-requested a review January 31, 2021 14:43

@chaspy chaspy left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense 👍
I'll implement this approach to other exporters later, thanks!

@chaspy
chaspy merged commit 3e13a64 into chaspy:main Jan 31, 2021
@suzuki-shunsuke
suzuki-shunsuke deleted the fix/validate-params-before-loop branch January 31, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants