Skip to content

chore(go-github): update go-github to v33 - #6

Merged
chaspy merged 3 commits into
chaspy:mainfrom
suzuki-shunsuke:chore/update-go-github
Jan 31, 2021
Merged

chaspy merged 3 commits into
chaspy:mainfrom
suzuki-shunsuke:chore/update-go-github

Conversation

@suzuki-shunsuke

@suzuki-shunsuke suzuki-shunsuke commented Jan 28, 2021 •

Copy link
Copy Markdown
Contributor

Same as chaspy/github-pr-prometheus-exporter#10

https://github.com/golang/go/wiki/Modules#semantic-import-versioning

Update github.com/google/go-github/github (v17.0.0) to github.com/google/go-github/v33/github.

If we don't have a special reason, let's use the latest stable version.

google/go-github@v17.0.0...v33.0.0

@suzuki-shunsuke
suzuki-shunsuke marked this pull request as draft January 28, 2021 11:51
@suzuki-shunsuke
suzuki-shunsuke marked this pull request as ready for review January 28, 2021 12:14

@chaspy chaspy left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chaspy
chaspy merged commit 7c0aedc into chaspy:main Jan 31, 2021
@suzuki-shunsuke
suzuki-shunsuke deleted the chore/update-go-github branch January 31, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants