[SSR Agent] Issue Fix (285): Trust system ripgrep path in Nix environments - #287
Open
joneba-google wants to merge 1 commit into
Open
joneba-google wants to merge 1 commit into
joneba-google wants to merge 1 commit into
Conversation
|
📊 PR Size: size/XS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #285
Original Issue: #285
Context & Problem
The Gemini CLI hangs during execution when running in Nix environments because system ripgrep binaries located inside the
/nix/storedirectory are rejected as untrusted. This occurs becauseisTrustedSystemPathvalidates executive paths against a hardcoded list of trusted prefixes which previously did not include/nix/store.Detailed Changes
/nix/storeto thetrustedPrefixesarray for non-Windows (POSIX) environments inisTrustedSystemPath.isTrustedSystemPathtest suite asserting that the path/nix/store/abc123def456-ripgrep-14.1.0/bin/rgis successfully evaluated as a trusted system path.Verification