Repository navigation
docs: check the docs/fork ignore rule with --no-index - #122
Merged
cameronsjo merged 1 commit intoOct 21, 2026
Merged
Conversation
The #115 entry's regression check ran `git check-ignore docs/fork/CHANGES.md` and expected exit 1. That file is tracked, and git check-ignore skips tracked paths unless given --no-index, so the check exits 1 even when /docs/* ignores the file again. Removing both !/docs/fork/ lines from .gitignore leaves the old check at 1 and moves the --no-index form to 0. Raised by CodeRabbit on #115. Claude-Session: https://claude.ai/code/session_016MXBYW3meTL95gcAeo2HFm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
docs/fork/CHANGES.mdentry from #115 says its regression check isgit check-ignore docs/fork/CHANGES.mdexiting 1. That file is tracked, andgit check-ignoreskips tracked paths unless it gets--no-index. So the old check exits 1 even when/docs/*ignores the file again, and it can never catch the regression it names.The entry now uses
git check-ignore --no-index docs/fork/CHANGES.mdand says why. This PR corrects the #115 entry itself, so it adds no entry of its own.CodeRabbit raised this on #115 after it merged.
Check
master, both forms exit 1.!/docs/fork/lines removed from.gitignore: the old form still exits 1, and the--no-indexform exits 0..gitignorewas restored after.Part of the owned-concessions sweep (cameronsjo/cadence-ecosystem#649).
Generated by Claude Code
Summary by CodeRabbit