Skip to content

docs: check the docs/fork ignore rule with --no-index - #122

Merged
cameronsjo merged 1 commit into
masterfrom
claude/project-thread-vhm86r-herdr-check-ignore-no-index
Oct 21, 2026
Merged

cameronsjo merged 1 commit into
masterfrom
claude/project-thread-vhm86r-herdr-check-ignore-no-index

Conversation

@cameronsjo

@cameronsjo cameronsjo commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

What

The docs/fork/CHANGES.md entry from #115 says its regression check is git check-ignore docs/fork/CHANGES.md exiting 1. That file is tracked, and git check-ignore skips tracked paths unless it gets --no-index. So the old check exits 1 even when /docs/* ignores the file again, and it can never catch the regression it names.

The entry now uses git check-ignore --no-index docs/fork/CHANGES.md and says why. This PR corrects the #115 entry itself, so it adds no entry of its own.

CodeRabbit raised this on #115 after it merged.

Check

  • On master, both forms exit 1.
  • With both !/docs/fork/ lines removed from .gitignore: the old form still exits 1, and the --no-index form exits 0. .gitignore was restored after.
  • Docs only. No code changes.

Part of the owned-concessions sweep (cameronsjo/cadence-ecosystem#649).


Generated by Claude Code

Summary by CodeRabbit

  • Tests
    • Improved the regression check for the tracked changes ledger to accurately validate ignore-rule exceptions.
    • Continued requiring both relevant directory exceptions.

The #115 entry's regression check ran `git check-ignore
docs/fork/CHANGES.md` and expected exit 1. That file is tracked, and
git check-ignore skips tracked paths unless given --no-index, so the
check exits 1 even when /docs/* ignores the file again. Removing both
!/docs/fork/ lines from .gitignore leaves the old check at 1 and moves
the --no-index form to 0.

Raised by CodeRabbit on #115.

Claude-Session: https://claude.ai/code/session_016MXBYW3meTL95gcAeo2HFm
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: 9d80833c-133b-4588-9ab4-2d76563a9fdb
📥 Commits

Reviewing files that changed from the base of the PR and between b853848 and c091761.

📒 Files selected for processing: 1
  • docs/fork/CHANGES.md

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

📝 Walkthrough

The regression check for docs/fork/CHANGES.md now uses git check-ignore --no-index. It retains the requirement for both !/docs/fork/ exceptions.

Changes: Ignore-rule regression check

Layer / File(s) Summary
Update regression command
docs/fork/CHANGES.md
The regression command checks ignore rules without Git’s tracked-path shortcut. It retains the expected exit status and .gitignore collision note.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: claude

Merge Risk: ⚪ Minimal · up to c0917

The regression documentation is corrected and the PR is mergeable.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the documentation change to use the --no-index option when checking the docs/fork ignore rule.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the ledger line,
While ignore rules fall into line.
No tracked-path shortcut gets in the way,
The fork exceptions still hold sway.
Hop, hop, the check is done today!

Comment @coderabbitai help to get the list of available commands.

@cameronsjo
cameronsjo merged commit 6a21adb into master Oct 21, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants