[cameronsjo]

Requested by Cameron · project thread

What

Upstream fixed the out-of-range w_N / N workspace-id panic with the same filter as fork PR #81 (upstream herdrdev#5171). The 2026-10-12 sync kept the fork's copy of the line and its comment. So parse_workspace_id still diverged from upstream, with no difference in behavior.

parse_workspace_id in src/app/ids.rs now matches upstream master (143bf5f) exactly. The fork's .filter(|index| *index < len) and its four-line comment become upstream's .filter(|&index| index < len). The fork's request-path tests and the three hand-rolled < len guards stay.

In docs/fork/CHANGES.md, the #81 entry is marked retired for the parser filter, like the 2026-09-17 retired entry. A short new entry records this PR.

Check

• The function matches upstream master byte for byte (diffed against raw.githubusercontent.com/herdrdev/herdr/master/src/app/ids.rs, master at 143bf5f).
• cargo fmt --check: pass.
• Not run: cargo test. The vendored libghostty-vt build fetches its Zig packages from deps.files.ghostty.org, which this session's proxy blocks. I installed Zig 0.16.0 and seeded uucode by hand (hash verified), but zlib, highway, wuffs and the themes tarball also need that host. CI covers it: cargo nextest run --locked -E 'test(positional_workspace_id) + test(numeric_workspace_ids_beyond_the_last_workspace_are_not_found)'.

Part of the owned-concessions sweep (cameronsjo/cadence-ecosystem#649).

---

Generated by Claude Code

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 2 billable files and costs up to $0.50.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 53 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Essentials
• Run ID: 6c01fdb6-9920-4ee7-877a-ea5f15eb2e00

📥 Commits

Reviewing files that changed from the base of the PR and between 0919977 and 30093a9.

📒 Files selected for processing: 2

• docs/fork/CHANGES.md
• src/app/ids.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}