Repository navigation
fix(pi-coding-agent): avoid double-counting token usage and cost - #2672
Merged
Merged
Conversation
> 🤖 **This text was AI-generated.** Pi Coding Agent instrumentation copied each child LLM's token usage onto the AgentSession.prompt task span. Trace rollups counted both, doubling token totals and estimated cost. Before, two calls using 29 prompt tokens each produced: ```text AgentSession.prompt (task): 58 prompt tokens |-- LLM call: 29 prompt tokens `-- LLM call: 29 prompt tokens Trace rollup: 116 prompt tokens ``` Keep usage on the child LLM spans and record only timing metrics on the prompt span. Remove both the stream-result aggregation and the turn_end fallback. ```text AgentSession.prompt (task): timing only |-- LLM call: 29 prompt tokens `-- LLM call: 29 prompt tokens Trace rollup: 58 prompt tokens ``` Regression coverage checks cached usage across multiple turns, deferred prompts, and exported traces for wrapped and automatic instrumentation. Fixes #2659
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 tasks done
Stephen Belanger (Qard)
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi Coding Agent instrumentation copied each child LLM's token usage onto the
AgentSession.prompt task span. Trace rollups counted both, doubling token totals
and estimated cost.
Before, two calls using 29 prompt tokens each produced:
Keep usage on the child LLM spans and record only timing metrics on the prompt
span. Remove both the stream-result aggregation and the turn_end fallback.
Regression coverage checks cached usage across multiple turns, deferred prompts,
and exported traces for wrapped and automatic instrumentation.
Fixes #2659
resolves https://linear.app/braintrustdata/issue/SDK-621