Repository navigation
fix(pi-coding-agent): Stop double-counting prompt span token usage - #2660
Closed
Sharon Adhitya (sharonadhitya) wants to merge 1 commit into
Closed
Sharon Adhitya (sharonadhitya) wants to merge 1 commit into
Sharon Adhitya (sharonadhitya) wants to merge 1 commit into
Conversation
Member
|
thanks for the pr Sharon Adhitya (@sharonadhitya). Going with #2672 instead here |
Sharon Adhitya (sharonadhitya)
deleted the
fix/pi-token-double-counting
branch
October 26, 2026 13:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentSession.prompttask span.llmspans only. The prompt span still keeps its input, output, model metadata, and duration.Fixes Pi Coding Agent instrumentation double-counts tokens and estimated cost in trace rollups (AgentSession.prompt carries summed LLM usage) #2659
Test plan
pnpm exec vitest run src/instrumentation/plugins/pi-coding-agent-plugin.test.tspnpm exec vitest run src/instrumentation/plugins/pi-coding-agent-context.test.tspnpm exec vitest run src/wrappers/pi-coding-agent.test.tspnpm --filter @braintrust/js-e2e-tests run test:e2e -- pi-coding-agent-instrumentation