Document bevy_gizmos#8186
Merged
Merged
Conversation
Member
|
Once there's module docs this LGTM. Solid work so far, and I like the gratuitous use of doc examples. |
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
james7132
approved these changes
Mar 28, 2023
Co-authored-by: James Liu <contact@jamessliu.com>
Contributor
Author
|
Thanks for the review! |
Member
Ah yeah, you're right. Thanks for noting that. |
mockersf
approved these changes
Mar 28, 2023
45 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix #8179
Solution
#![warn(missing_docs)]and document all public items. All methods onGizmoshave doc examples.GizmoBufferto be directly onGizmosand madeGizmoBufferprivate. This means the methods onGizmoswill show up on its doc page.