[Merged by Bors] - Fix dynamic linking (on linux)#7333
Conversation
alice-i-cecile
added
the
A-Diagnostics
mockersf
left a comment
mockersf
left a comment
There was a problem hiding this comment.
Could you give the feature a more explicit name like dynamic_linking?
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
I can confirm that non-dynamic linking still works as expected and the changes make sense to me, but I can't test the dynamic feature on my machine.
|
I like the idea of renaming the dynamic feature, but I think this should be done in a separate PR that isn't intended to fix a bug. |
alice-i-cecile
added
the
S-Ready-For-Final-Review
You could argue that the bug was caused by the feature name not being explicit... |
Nilirad
left a comment
Nilirad
left a comment
There was a problem hiding this comment.
Tested. It works on my machine!
Agreed! |
|
bors r+ |
# Problemo Some code in #5911 and #5454 does not compile with dynamic linking enabled. The code is behind a feature gate to prevent dynamically linked builds from breaking, but it's not quite set up correctly. ## Solution Forward the `dynamic` feature flag to the `bevy_diagnostic` crate and gate the code behind it. Co-authored-by: devil-ira <justthecooldude@gmail.com>
|
Pull request successfully merged into main. Build succeeded:
|
bors
Bot
changed the title
# Problemo Some code in bevyengine#5911 and bevyengine#5454 does not compile with dynamic linking enabled. The code is behind a feature gate to prevent dynamically linked builds from breaking, but it's not quite set up correctly. ## Solution Forward the `dynamic` feature flag to the `bevy_diagnostic` crate and gate the code behind it. Co-authored-by: devil-ira <justthecooldude@gmail.com>
5 participants
Problemo
Some code in #5911 and #5454 does not compile with dynamic linking enabled.
The code is behind a feature gate to prevent dynamically linked builds from breaking, but it's not quite set up correctly.
Solution
Forward the
dynamicfeature flag to thebevy_diagnosticcrate and gate the code behind it.