Skip to content

[Merged by Bors] - Fix overflow scaling for images#7142

Closed
mockersf wants to merge 2 commits into
bevyengine:mainfrom
mockersf:fix-overflow-scaling-for-images
Closed

[Merged by Bors] - Fix overflow scaling for images#7142
mockersf wants to merge 2 commits into
bevyengine:mainfrom
mockersf:fix-overflow-scaling-for-images

Conversation

@mockersf

@mockersf mockersf commented Jan 9, 2023

Copy link
Copy Markdown
Member

Objective

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets labels Jan 9, 2023

@rparrett rparrett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested image and text clipping at various scale factors.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 9, 2023
@alice-i-cecile

Copy link
Copy Markdown
Member

bors r+

bors Bot pushed a commit that referenced this pull request Jan 9, 2023
# Objective

- Fixes #4057 
- Do not multiply position by scale factor
@bors

bors Bot commented Jan 9, 2023

Copy link
Copy Markdown

Build failed (retrying...):

bors Bot pushed a commit that referenced this pull request Jan 9, 2023
# Objective

- Fixes #4057 
- Do not multiply position by scale factor
@bors bors Bot changed the title Fix overflow scaling for images [Merged by Bors] - Fix overflow scaling for images Jan 9, 2023
@bors bors Bot closed this Jan 9, 2023
james7132 pushed a commit to james7132/bevy that referenced this pull request Jan 21, 2023
# Objective

- Fixes bevyengine#4057 
- Do not multiply position by scale factor
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
# Objective

- Fixes bevyengine#4057 
- Do not multiply position by scale factor
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- Fixes bevyengine#4057 
- Do not multiply position by scale factor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Distortion at the edges of an Overflow::Hidden UI node

3 participants