Skip to content

[Merged by Bors] - Add a reparented_to method to GlobalTransform - #7020

Closed
nicopap wants to merge 1 commit into
bevyengine:mainfrom
nicopap:transform-hierarchy-commands
Closed

[Merged by Bors] - Add a reparented_to method to GlobalTransform#7020
nicopap wants to merge 1 commit into
bevyengine:mainfrom
nicopap:transform-hierarchy-commands

Conversation

@nicopap

@nicopap nicopap commented Dec 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Objective

It is often necessary to update an entity's parent while keeping its GlobalTransform static. Currently it is cumbersome and error-prone (two questions in the discord #help channel in the past week)

Solution

  • Add a reparented_to method to GlobalTransform

Changelog

  • Add a reparented_to method to GlobalTransform

@nicopap nicopap added C-Feature A new feature, making something new possible C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Transform Translations, rotations and scales A-Hierarchy labels Dec 24, 2022
@nicopap

nicopap commented Dec 24, 2022

Copy link
Copy Markdown
Contributor Author

@nicopap

nicopap commented Dec 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Also note that I'm not 100% the math and the tests are correct. I'll give an update later once I'm confident this is correct.

UPDATE: I have now visually tested the reparented_to method, and I'm convinced this works.

@nicopap
nicopap marked this pull request as draft December 24, 2022 12:00
@nicopap
nicopap marked this pull request as ready for review December 24, 2022 14:26
@nicopap nicopap mentioned this pull request Dec 24, 2022
Closed
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 24, 2022
@alice-i-cecile

alice-i-cecile commented Dec 25, 2022

Copy link
Copy Markdown
Member

bors r+

bors Bot pushed a commit that referenced this pull request Dec 25, 2022
@nicopap
Add a reparented_to method to GlobalTransform (#7020)
07b21aa 
# Objective

It is often necessary  to update an entity's parent while keeping its GlobalTransform static. Currently it is cumbersome and error-prone (two questions in the discord `#help` channel in the past week)

- Part 1 of #5475
- Part 2: #7024.

## Solution

- Add a `reparented_to` method to `GlobalTransform`

---

## Changelog

- Add a `reparented_to` method to `GlobalTransform`
@bors

bors Bot commented Dec 25, 2022

Copy link
Copy Markdown

Build failed (retrying...):

bors Bot pushed a commit that referenced this pull request Dec 25, 2022
@nicopap
Add a reparented_to method to GlobalTransform (#7020)
b8a9933 
# Objective

It is often necessary  to update an entity's parent while keeping its GlobalTransform static. Currently it is cumbersome and error-prone (two questions in the discord `#help` channel in the past week)

- Part 1 of #5475
- Part 2: #7024.

## Solution

- Add a `reparented_to` method to `GlobalTransform`

---

## Changelog

- Add a `reparented_to` method to `GlobalTransform`
@bors

bors Bot commented Dec 25, 2022

Copy link
Copy Markdown

Pull request successfully merged into main.

Build succeeded:

@bors bors Bot changed the title Add a reparented_to method to GlobalTransform [Merged by Bors] - Add a reparented_to method to GlobalTransform Dec 25, 2022
@bors bors Bot closed this Dec 25, 2022
bors Bot pushed a commit that referenced this pull request Jan 12, 2023
@nicopap
Add an extension trait to EntityCommands to update hierarchy while …
16dda50 
…preserving `GlobalTransform` (#7024)

# Objective

It is often necessary  to update an entity's parent
while keeping its GlobalTransform static. Currently
it is cumbersome and error-prone (two questions in
the discord `#help` channel in the past week)

- Part 2, resolves #5475
- Builds on: #7020.

## Solution

- Added the `BuildChildrenTransformExt` trait, it is part
  of `bevy::prelude` and adds the following methods to `EntityCommands`:
  - `set_parent_in_place`: Change the parent of an entity and
    update its `Transform` in order to preserve its `GlobalTransform` after the parent change
  - `remove_parent_in_place`: Remove an entity from a hierarchy,
    while preserving its `GlobalTransform`.

---

## Changelog


- Added the `BuildChildrenTransformExt` trait, it is part
  of `bevy::prelude` and adds the following methods to `EntityCommands`:
  - `set_parent_in_place`: Change the parent of an entity and
    update its `Transform` in order to preserve its `GlobalTransform` after the parent change
  - `remove_parent_in_place`: Remove an entity from a hierarchy,
    while preserving its `GlobalTransform`.

Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
bors Bot pushed a commit that referenced this pull request Jan 12, 2023
@nicopap
Add an extension trait to EntityCommands to update hierarchy while …
689eab6 
…preserving `GlobalTransform` (#7024)

# Objective

It is often necessary  to update an entity's parent
while keeping its GlobalTransform static. Currently
it is cumbersome and error-prone (two questions in
the discord `#help` channel in the past week)

- Part 2, resolves #5475
- Builds on: #7020.

## Solution

- Added the `BuildChildrenTransformExt` trait, it is part
  of `bevy::prelude` and adds the following methods to `EntityCommands`:
  - `set_parent_in_place`: Change the parent of an entity and
    update its `Transform` in order to preserve its `GlobalTransform` after the parent change
  - `remove_parent_in_place`: Remove an entity from a hierarchy,
    while preserving its `GlobalTransform`.

---

## Changelog


- Added the `BuildChildrenTransformExt` trait, it is part
  of `bevy::prelude` and adds the following methods to `EntityCommands`:
  - `set_parent_in_place`: Change the parent of an entity and
    update its `Transform` in order to preserve its `GlobalTransform` after the parent change
  - `remove_parent_in_place`: Remove an entity from a hierarchy,
    while preserving its `GlobalTransform`.

Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
@nicopap nicopap mentioned this pull request Jan 18, 2023
Closed
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@nicopap @alradish
Add a reparented_to method to GlobalTransform (bevyengine#7020)
fffe102 
# Objective

It is often necessary  to update an entity's parent while keeping its GlobalTransform static. Currently it is cumbersome and error-prone (two questions in the discord `#help` channel in the past week)

- Part 1 of bevyengine#5475
- Part 2: bevyengine#7024.

## Solution

- Add a `reparented_to` method to `GlobalTransform`

---

## Changelog

- Add a `reparented_to` method to `GlobalTransform`
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@nicopap @alradish
Add an extension trait to EntityCommands to update hierarchy while …
77f7a4f 
…preserving `GlobalTransform` (bevyengine#7024)

# Objective

It is often necessary  to update an entity's parent
while keeping its GlobalTransform static. Currently
it is cumbersome and error-prone (two questions in
the discord `#help` channel in the past week)

- Part 2, resolves bevyengine#5475
- Builds on: bevyengine#7020.

## Solution

- Added the `BuildChildrenTransformExt` trait, it is part
  of `bevy::prelude` and adds the following methods to `EntityCommands`:
  - `set_parent_in_place`: Change the parent of an entity and
    update its `Transform` in order to preserve its `GlobalTransform` after the parent change
  - `remove_parent_in_place`: Remove an entity from a hierarchy,
    while preserving its `GlobalTransform`.

---

## Changelog


- Added the `BuildChildrenTransformExt` trait, it is part
  of `bevy::prelude` and adds the following methods to `EntityCommands`:
  - `set_parent_in_place`: Change the parent of an entity and
    update its `Transform` in order to preserve its `GlobalTransform` after the parent change
  - `remove_parent_in_place`: Remove an entity from a hierarchy,
    while preserving its `GlobalTransform`.

Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@nicopap @ItsDoot
Add a reparented_to method to GlobalTransform (bevyengine#7020)
67de136 
# Objective

It is often necessary  to update an entity's parent while keeping its GlobalTransform static. Currently it is cumbersome and error-prone (two questions in the discord `#help` channel in the past week)

- Part 1 of bevyengine#5475
- Part 2: bevyengine#7024.

## Solution

- Add a `reparented_to` method to `GlobalTransform`

---

## Changelog

- Add a `reparented_to` method to `GlobalTransform`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@nicopap @ItsDoot
Add an extension trait to EntityCommands to update hierarchy while …
df51dc1 
…preserving `GlobalTransform` (bevyengine#7024)

# Objective

It is often necessary  to update an entity's parent
while keeping its GlobalTransform static. Currently
it is cumbersome and error-prone (two questions in
the discord `#help` channel in the past week)

- Part 2, resolves bevyengine#5475
- Builds on: bevyengine#7020.

## Solution

- Added the `BuildChildrenTransformExt` trait, it is part
  of `bevy::prelude` and adds the following methods to `EntityCommands`:
  - `set_parent_in_place`: Change the parent of an entity and
    update its `Transform` in order to preserve its `GlobalTransform` after the parent change
  - `remove_parent_in_place`: Remove an entity from a hierarchy,
    while preserving its `GlobalTransform`.

---

## Changelog


- Added the `BuildChildrenTransformExt` trait, it is part
  of `bevy::prelude` and adds the following methods to `EntityCommands`:
  - `set_parent_in_place`: Change the parent of an entity and
    update its `Transform` in order to preserve its `GlobalTransform` after the parent change
  - `remove_parent_in_place`: Remove an entity from a hierarchy,
    while preserving its `GlobalTransform`.

Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
@nicopap
nicopap deleted the transform-hierarchy-commands branch August 30, 2023 13:49
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events and removed A-Hierarchy labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes
+1 more reviewer
@joseph-gio joseph-gio joseph-gio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events A-Transform Translations, rotations and scales C-Feature A new feature, making something new possible C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicopap @alice-i-cecile @joseph-gio