Skip to content

[Merged by Bors] - Remove ImageMode#6674

Closed
ickshonpe wants to merge 3 commits into
bevyengine:mainfrom
ickshonpe:remove-image-mode-keep-aspect
Closed

[Merged by Bors] - Remove ImageMode#6674
ickshonpe wants to merge 3 commits into
bevyengine:mainfrom
ickshonpe:remove-image-mode-keep-aspect

Conversation

@ickshonpe

@ickshonpe ickshonpe commented Nov 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Objective

Delete ImageMode. It doesn't do anything except mislead people into thinking it controls the aspect ratio of images somehow.

Fixes #3933 and #6637

Solution

Delete ImageMode

Changelog

Removes the ImageMode enum.
Removes the image_mode field from ImageBundle
Removes the With<ImageMode> query filter from image_node_system
Renames image_node_system to update_image_calculated_size_system

tim-blackbird
tim-blackbird approved these changes Nov 18, 2022
View reviewed changes

@tim-blackbird tim-blackbird left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the git history and it's impressive that this component managed to exist for 2 years without ever functioning.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets labels Nov 18, 2022
alice-i-cecile
alice-i-cecile requested changes Nov 18, 2022
View reviewed changes

@alice-i-cecile alice-i-cecile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unfortunate :( Given that it does nothing ATM, I think this is better than leaving it.

Comment thread crates/bevy_ui/src/widget/image.rs Outdated
mockersf
mockersf approved these changes Nov 18, 2022
View reviewed changes

@mockersf mockersf left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively it wouldn't be too complicated to make it work and add additional ImageMode (fixed x, fixed y, ...).
But I'm not personally interested in that feature, so ok to remove it

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Nov 18, 2022
@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Nov 18, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 18, 2022
@cart

cart commented Nov 18, 2022

Copy link
Copy Markdown
Member

bors r+

bors Bot pushed a commit that referenced this pull request Nov 18, 2022
@ickshonpe
Remove ImageMode (#6674)
5972879 
# Objective

Delete `ImageMode`. It doesn't do anything except mislead people into thinking it controls the aspect ratio of images somehow.

Fixes #3933 and #6637

## Solution

Delete `ImageMode`

## Changelog

Removes the `ImageMode` enum.
Removes the `image_mode` field from `ImageBundle`
Removes the `With<ImageMode>` query filter from `image_node_system`
Renames `image_node_system` to` update_image_calculated_size_system`
@bors

bors Bot commented Nov 18, 2022

Copy link
Copy Markdown

Pull request successfully merged into main.

Build succeeded:

@bors bors Bot changed the title Remove ImageMode [Merged by Bors] - Remove ImageMode Nov 18, 2022
@bors bors Bot closed this Nov 18, 2022
@bzm3r bzm3r mentioned this pull request Nov 19, 2022
Closed
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@ickshonpe @alradish
Remove ImageMode (bevyengine#6674)
f68999d 
# Objective

Delete `ImageMode`. It doesn't do anything except mislead people into thinking it controls the aspect ratio of images somehow.

Fixes bevyengine#3933 and bevyengine#6637

## Solution

Delete `ImageMode`

## Changelog

Removes the `ImageMode` enum.
Removes the `image_mode` field from `ImageBundle`
Removes the `With<ImageMode>` query filter from `image_node_system`
Renames `image_node_system` to` update_image_calculated_size_system`
@mockersf mockersf mentioned this pull request Jan 24, 2023
Open
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@ickshonpe @ItsDoot
Remove ImageMode (bevyengine#6674)
8eeac89 
# Objective

Delete `ImageMode`. It doesn't do anything except mislead people into thinking it controls the aspect ratio of images somehow.

Fixes bevyengine#3933 and bevyengine#6637

## Solution

Delete `ImageMode`

## Changelog

Removes the `ImageMode` enum.
Removes the `image_mode` field from `ImageBundle`
Removes the `With<ImageMode>` query filter from `image_node_system`
Renames `image_node_system` to` update_image_calculated_size_system`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes
@mockersf mockersf mockersf approved these changes
+1 more reviewer
@tim-blackbird tim-blackbird tim-blackbird approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.10

Development

Successfully merging this pull request may close these issues.

Strange behavior of ImageMode::KeepAspect

5 participants

@ickshonpe @cart @alice-i-cecile @mockersf @tim-blackbird