[Merged by Bors] - REMOVE unsound lifetime annotations on EntityMut - #4096
Closed
BoxyUwU wants to merge 5 commits into
Closed
[Merged by Bors] - REMOVE unsound lifetime annotations on EntityMut#4096BoxyUwU wants to merge 5 commits into
EntityMut#4096BoxyUwU wants to merge 5 commits into
Conversation
alice-i-cecile
added
P-High
BoxyUwU
force-pushed
the
port_ptrification_soundnes_fix
branch
from
March 4, 2022 04:08
a1cd173 to
7e4eacd
Compare
BoxyUwU
changed the title
'w lifetime >:(Entity(Ref/Mut) >:(
Guvante
approved these changes
Mar 17, 2022
alice-i-cecile
approved these changes
Mar 17, 2022
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
The UB is clear, and upon examining this more closely, the 'w lifetime is clearly incorrect. I've left some comments to improve the docs and safety comments.
BoxyUwU
force-pushed
the
port_ptrification_soundnes_fix
branch
from
March 17, 2022 22:07
407a2de to
45da4b4
Compare
Member
|
@BoxyUwU can you resolve conversations now? :) |
BoxyUwU
added
the
S-Ready-For-Final-Review
BoxyUwU
changed the title
Entity(Ref/Mut) >:(Entity(Ref/Mut)
TheRawMeatball
approved these changes
Mar 28, 2022
BoxyUwU
changed the title
Entity(Ref/Mut)EntityMut
BoxyUwU
force-pushed
the
port_ptrification_soundnes_fix
branch
from
March 31, 2022 19:32
e49da1f to
7203f9e
Compare
BoxyUwU
force-pushed
the
port_ptrification_soundnes_fix
branch
from
April 3, 2022 09:31
7203f9e to
05f0168
Compare
Member
|
bors r+ |
bors
Bot
changed the title
EntityMutEntityMut
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
Fixes bevyengine#3408 bevyengine#3001 also solves this but I dont see it getting merged any time soon so... # Objective make bevy ecs a lil bit less unsound ## Solution make `EntityMut::get_component_mut` return borrows from self instead of `'w`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
Fixes bevyengine#3408 bevyengine#3001 also solves this but I dont see it getting merged any time soon so... # Objective make bevy ecs a lil bit less unsound ## Solution make `EntityMut::get_component_mut` return borrows from self instead of `'w`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3408
#3001 also solves this but I dont see it getting merged any time soon so...
Objective
make bevy ecs a lil bit less unsound
Solution
make
EntityMut::get_component_mutreturn borrows from self instead of'w