Run prepass_build_indirect_parameters if there is any prepass#24113
Merged
alice-i-cecile merged 1 commit intoMay 5, 2026
Merged
Conversation
kfc35
added
C-Bug
kfc35
approved these changes
May 4, 2026
kfc35
added
the
D-Straightforward
Member
|
Broken by the force push noted in #24130; you'll need to clean up the Git history per @cart's message. |
beicause
force-pushed
the
fix-prepass-without-depth-prepass
branch
from
8f18582 to
c43594c
Compare
kfc35
approved these changes
May 5, 2026
JMS55
approved these changes
May 5, 2026
JMS55
added
S-Ready-For-Final-Review
allocatedribble
added a commit
to allocatedribble/bevy
that referenced
this pull request
May 5, 2026
Cherry-pick isolated upstream runtime and correctness fixes from bevyengine/bevy after upstream/main was force-updated away from the previously merged history. Included upstream PRs: - bevyengine#24077: store derived resources in sparse sets and add ECS resource benchmarks - bevyengine#24113: run prepass indirect parameter building for any active prepass - bevyengine#24135: skip UI clip tests when overflow is visible and reject non-invertible transforms Skipped the rewritten full upstream merge because it overlaps local dirty render diagnostics work and would drop fork-local files from the forced-update range. Validation: cargo fmt --check -p benches -p bevy_ecs_macros -p bevy_pbr -p bevy_ui; cargo check -p bevy_ecs_macros -p bevy_pbr -p bevy_ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #24097
Indirect parameters are not built in early prepass if depth prepass and shadow map are not enabled:
Solution
Run prepass_build_indirect_parameters if there is any prepass, not only depth prepass.
Testing
motion_blurexample without shadow map is fixed: