Fix DynamicTextureAtlasBuilder incorrectly padding added textures.#23091
Merged
Conversation
DynamicTextureAtlasBuilder incorrectly padding added textures.
Contributor
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
1142dd2 to
342d8c7
Compare
342d8c7 to
2ace776
Compare
mockersf
approved these changes
Feb 21, 2026
ickshonpe
suggested changes
Feb 21, 2026
ickshonpe
left a comment
Contributor
There was a problem hiding this comment.
Looks good, except I think padding for fonts should probably stay at 2 pixels, at least by default.
This reverts commit 2ace776.
ickshonpe
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
DynamicTextureAtlasBuilderwould allocate glyph size + padding, and then copy the glyph into that rectangle - but this means that copying would start at (0,0) meaning we would "blend" with the top and left edges (which breaks things).Testing
linblackin the Text screenshot look substantially better!Note this is orthogonal to #23056 which is about
TextureAtlasBuilder, notDynamicTextureAtlasBuilder.