Skip to content

move Hdr to bevy_camera#22683

Merged
james7132 merged 2 commits into
bevyengine:mainfrom
atlv24:ad/move-hdr
Jan 24, 2026
Merged

move Hdr to bevy_camera#22683
james7132 merged 2 commits into
bevyengine:mainfrom
atlv24:ad/move-hdr

Conversation

@atlv24

@atlv24 atlv24 commented Jan 24, 2026

Copy link
Copy Markdown
Contributor

Objective

  • whether a Camera needs to draw Hdr content or not is an aspect of scene description
  • as such, it should live in a non-rendering crate

Solution

  • move it to bevy_camera
  • dont extract it to the render world anymore. audited all usages of it and none are in the render world queries, instead ExtractedCamera::hdr is used.

Testing

  • manual spot check of a few examples
  • example runner regression test

@atlv24 atlv24 added A-Rendering Drawing game state to the screen M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 24, 2026
@alice-i-cecile alice-i-cecile requested a review from kfc35 January 24, 2026 19:58
@atlv24

atlv24 commented Jan 24, 2026

Copy link
Copy Markdown
Contributor Author

pixel smeagol looks good

@james7132 james7132 removed the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jan 24, 2026
@james7132 james7132 added this pull request to the merge queue Jan 24, 2026
Merged via the queue into bevyengine:main with commit badca1c Jan 24, 2026
38 checks passed
@mockersf

Copy link
Copy Markdown
Member

as reported by pixel eagle, this broke the solari example:

error[E0432]: unresolved import `bevy_render::view::Hdr`
  --> crates/bevy_solari/src/pathtracer/mod.rs:14:5
   |
14 |     view::Hdr,
   |     ^^^^^^^^^ no `Hdr` in `view`
   |
   = help: consider importing one of these items instead:
           bevy_camera::Hdr
           bevy_image::ImageFormat::Hdr
           bevy_render::render_resource::AstcChannel::Hdr

@atlv24 atlv24 mentioned this pull request Jan 25, 2026
@atlv24

atlv24 commented Jan 25, 2026

Copy link
Copy Markdown
Contributor Author

as reported by pixel eagle, this broke the solari example:

error[E0432]: unresolved import `bevy_render::view::Hdr`
  --> crates/bevy_solari/src/pathtracer/mod.rs:14:5
   |
14 |     view::Hdr,
   |     ^^^^^^^^^ no `Hdr` in `view`
   |
   = help: consider importing one of these items instead:
           bevy_camera::Hdr
           bevy_image::ImageFormat::Hdr
           bevy_render::render_resource::AstcChannel::Hdr

looks fine on main

github-merge-queue Bot pushed a commit that referenced this pull request Jan 25, 2026
missed it during #22683 oops

can this be checked by ci?
@mockersf

Copy link
Copy Markdown
Member

my bad, you fixed it in the commit after the Pixel Eagle run. thanks!

@atlv24 atlv24 deleted the ad/move-hdr branch January 26, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants