Improve tests using broad queries (Query<Entity>, Query<()>, etc)#21685
Merged
Conversation
Trashtalk217
added
A-ECS
andriyDev
approved these changes
Oct 29, 2025
Trashtalk217
added
the
S-Needs-Review
alice-i-cecile
approved these changes
Oct 29, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Tests should be more resilient to entities added on
Worldcreation. This is necessary for resources-as-components to work without relying onDefaultQueryFilters.Solution
I've added an empty entity during
World::bootstrap()and ran the test suite (and CI). I've gone and fixed every test, except for the ones where it's not possible / doesn't make sense. Bothiter_entitiesanditer_entities_mutand their tests have been removed as they were deprecated in 0.17.