Skip to content

make bevy_input_focus dep on bevy_picking optional#21659

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
atlv24:ad/if-opt-picking
Oct 26, 2025
Merged

make bevy_input_focus dep on bevy_picking optional#21659
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
atlv24:ad/if-opt-picking

Conversation

@atlv24

@atlv24 atlv24 commented Oct 26, 2025

Copy link
Copy Markdown
Contributor

Objective

Solution

  • make bevy_input_focus dep on bevy_picking optional

Testing

  • ci

@atlv24 atlv24 marked this pull request as ready for review October 26, 2025 15:21
@atlv24 atlv24 mentioned this pull request Oct 26, 2025
Closed
@atlv24 atlv24 added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Oct 26, 2025
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide A-Windowing Platform-agnostic interface layer to run your app in A-UI Graphical user interfaces, styles, layouts, and widgets S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Oct 26, 2025
@github-actions

github-actions Bot commented Oct 26, 2025

Copy link
Copy Markdown
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Oct 26, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 26, 2025
@alice-i-cecile

alice-i-cecile commented Oct 26, 2025

Copy link
Copy Markdown
Member

Talked myself out of this needing a migration guide. It's technically breaking, but I can't actually think of any use cases that will be impacted, since this is only really observable in a full Bevy app.

Merged via the queue into bevyengine:main with commit 5530e8f Oct 26, 2025
57 checks passed
@atlv24 atlv24 deleted the ad/if-opt-picking branch December 17, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes
+1 more reviewer
@Zeophlite Zeophlite Zeophlite approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bevy_winit feature pulls in too many crates

3 participants

@atlv24 @alice-i-cecile @Zeophlite