Skip to content

Move view transformations to bevy_render #20313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superdump merged 1 commit into from
Jul 30, 2025
Merged

Move view transformations to bevy_render #20313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 55 additions & 70 deletions crates/bevy_pbr/src/render/view_transformations.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#import bevy_pbr::mesh_view_bindings as view_bindings
#import bevy_pbr::prepass_bindings
#import bevy_render::view

/// World space:
/// +y is up
Expand Down Expand Up @@ -31,204 +32,188 @@
// -----------------

/// Convert a view space position to world space
/// DEPRECATED: use bevy_render::view::position_view_to_world instead
fn position_view_to_world(view_pos: vec3<f32>) -> vec3<f32> {
let world_pos = view_bindings::view.world_from_view * vec4(view_pos, 1.0);
return world_pos.xyz;
return view::position_view_to_world(view_pos, view_bindings::view.world_from_view);
}

/// Convert a clip space position to world space
/// DEPRECATED: use bevy_render::view::position_clip_to_world instead
fn position_clip_to_world(clip_pos: vec4<f32>) -> vec3<f32> {
let world_pos = view_bindings::view.world_from_clip * clip_pos;
return world_pos.xyz;
return view::position_clip_to_world(clip_pos, view_bindings::view.world_from_clip);
}

/// Convert a ndc space position to world space
/// DEPRECATED: use bevy_render::view::position_ndc_to_world instead
fn position_ndc_to_world(ndc_pos: vec3<f32>) -> vec3<f32> {
let world_pos = view_bindings::view.world_from_clip * vec4(ndc_pos, 1.0);
return world_pos.xyz / world_pos.w;
return view::position_ndc_to_world(ndc_pos, view_bindings::view.world_from_clip);
}

/// Convert a view space direction to world space
/// DEPRECATED: use bevy_render::view::direction_view_to_world instead
fn direction_view_to_world(view_dir: vec3<f32>) -> vec3<f32> {
let world_dir = view_bindings::view.world_from_view * vec4(view_dir, 0.0);
return world_dir.xyz;
return view::direction_view_to_world(view_dir, view_bindings::view.world_from_view);
}

/// Convert a clip space direction to world space
/// DEPRECATED: use bevy_render::view::direction_clip_to_world instead
fn direction_clip_to_world(clip_dir: vec4<f32>) -> vec3<f32> {
let world_dir = view_bindings::view.world_from_clip * clip_dir;
return world_dir.xyz;
return view::direction_clip_to_world(clip_dir, view_bindings::view.world_from_clip);
}

// -----------------
// TO VIEW ---------
// -----------------

/// Convert a world space position to view space
/// DEPRECATED: use bevy_render::view::position_world_to_view instead
fn position_world_to_view(world_pos: vec3<f32>) -> vec3<f32> {
let view_pos = view_bindings::view.view_from_world * vec4(world_pos, 1.0);
return view_pos.xyz;
return view::position_world_to_view(world_pos, view_bindings::view.view_from_world);
}

/// Convert a clip space position to view space
/// DEPRECATED: use bevy_render::view::position_clip_to_view instead
fn position_clip_to_view(clip_pos: vec4<f32>) -> vec3<f32> {
let view_pos = view_bindings::view.view_from_clip * clip_pos;
return view_pos.xyz;
return view::position_clip_to_view(clip_pos, view_bindings::view.view_from_clip);
}

/// Convert a ndc space position to view space
/// DEPRECATED: use bevy_render::view::position_ndc_to_view instead
fn position_ndc_to_view(ndc_pos: vec3<f32>) -> vec3<f32> {
let view_pos = view_bindings::view.view_from_clip * vec4(ndc_pos, 1.0);
return view_pos.xyz / view_pos.w;
return view::position_ndc_to_view(ndc_pos, view_bindings::view.view_from_clip);
}

/// Convert a world space direction to view space
/// DEPRECATED: use bevy_render::view::direction_world_to_view instead
fn direction_world_to_view(world_dir: vec3<f32>) -> vec3<f32> {
let view_dir = view_bindings::view.view_from_world * vec4(world_dir, 0.0);
return view_dir.xyz;
return view::direction_world_to_view(world_dir, view_bindings::view.view_from_world);
}

/// Convert a clip space direction to view space
/// DEPRECATED: use bevy_render::view::direction_clip_to_view instead
fn direction_clip_to_view(clip_dir: vec4<f32>) -> vec3<f32> {
let view_dir = view_bindings::view.view_from_clip * clip_dir;
return view_dir.xyz;
return view::direction_clip_to_view(clip_dir, view_bindings::view.view_from_clip);
}

// -----------------
// TO PREV. VIEW ---
// -----------------

/// DEPRECATED: use bevy_render::view::position_world_to_view instead
fn position_world_to_prev_view(world_pos: vec3<f32>) -> vec3<f32> {
let view_pos = prepass_bindings::previous_view_uniforms.view_from_world *
vec4(world_pos, 1.0);
return view_pos.xyz;
return view::position_world_to_view(world_pos, prepass_bindings::previous_view_uniforms.view_from_world);
}

/// DEPRECATED: use bevy_render::view::position_world_to_ndc instead
fn position_world_to_prev_ndc(world_pos: vec3<f32>) -> vec3<f32> {
let ndc_pos = prepass_bindings::previous_view_uniforms.clip_from_world *
vec4(world_pos, 1.0);
return ndc_pos.xyz / ndc_pos.w;
return view::position_world_to_ndc(world_pos, prepass_bindings::previous_view_uniforms.clip_from_world);
}

// -----------------
// TO CLIP ---------
// -----------------

/// Convert a world space position to clip space
/// DEPRECATED: use bevy_render::view::position_world_to_clip instead
fn position_world_to_clip(world_pos: vec3<f32>) -> vec4<f32> {
let clip_pos = view_bindings::view.clip_from_world * vec4(world_pos, 1.0);
return clip_pos;
return view::position_world_to_clip(world_pos, view_bindings::view.clip_from_world);
}

/// Convert a view space position to clip space
/// DEPRECATED: use bevy_render::view::position_view_to_clip instead
fn position_view_to_clip(view_pos: vec3<f32>) -> vec4<f32> {
let clip_pos = view_bindings::view.clip_from_view * vec4(view_pos, 1.0);
return clip_pos;
return view::position_view_to_clip(view_pos, view_bindings::view.clip_from_view);
}

/// Convert a world space direction to clip space
/// DEPRECATED: use bevy_render::view::direction_world_to_clip instead
fn direction_world_to_clip(world_dir: vec3<f32>) -> vec4<f32> {
let clip_dir = view_bindings::view.clip_from_world * vec4(world_dir, 0.0);
return clip_dir;
return view::direction_world_to_clip(world_dir, view_bindings::view.clip_from_world);
}

/// Convert a view space direction to clip space
/// DEPRECATED: use bevy_render::view::direction_view_to_clip instead
fn direction_view_to_clip(view_dir: vec3<f32>) -> vec4<f32> {
let clip_dir = view_bindings::view.clip_from_view * vec4(view_dir, 0.0);
return clip_dir;
return view::direction_view_to_clip(view_dir, view_bindings::view.clip_from_view);
}

// -----------------
// TO NDC ----------
// -----------------

/// Convert a world space position to ndc space
/// DEPRECATED: use bevy_render::view::position_world_to_ndc instead
fn position_world_to_ndc(world_pos: vec3<f32>) -> vec3<f32> {
let ndc_pos = view_bindings::view.clip_from_world * vec4(world_pos, 1.0);
return ndc_pos.xyz / ndc_pos.w;
return view::position_world_to_ndc(world_pos, view_bindings::view.clip_from_world);
}

/// Convert a view space position to ndc space
/// DEPRECATED: use bevy_render::view::position_view_to_ndc instead
fn position_view_to_ndc(view_pos: vec3<f32>) -> vec3<f32> {
let ndc_pos = view_bindings::view.clip_from_view * vec4(view_pos, 1.0);
return ndc_pos.xyz / ndc_pos.w;
return view::position_view_to_ndc(view_pos, view_bindings::view.clip_from_view);
}

// -----------------
// DEPTH -----------
// -----------------

/// Retrieve the perspective camera near clipping plane
/// DEPRECATED: use bevy_render::view::perspective_camera_near instead
fn perspective_camera_near() -> f32 {
return view_bindings::view.clip_from_view[3][2];
return view::perspective_camera_near(view_bindings::view.clip_from_view);
}

/// Convert ndc depth to linear view z.
/// Note: Depth values in front of the camera will be negative as -z is forward
/// DEPRECATED: use bevy_render::view::depth_ndc_to_view_z instead
fn depth_ndc_to_view_z(ndc_depth: f32) -> f32 {
#ifdef VIEW_PROJECTION_PERSPECTIVE
return -perspective_camera_near() / ndc_depth;
#else ifdef VIEW_PROJECTION_ORTHOGRAPHIC
return -(view_bindings::view.clip_from_view[3][2] - ndc_depth) / view_bindings::view.clip_from_view[2][2];
#else
let view_pos = view_bindings::view.view_from_clip * vec4(0.0, 0.0, ndc_depth, 1.0);
return view_pos.z / view_pos.w;
#endif
return view::depth_ndc_to_view_z(ndc_depth, view_bindings::view.clip_from_view, view_bindings::view.view_from_clip);
}

/// Convert linear view z to ndc depth.
/// Note: View z input should be negative for values in front of the camera as -z is forward
/// DEPRECATED: use bevy_render::view::view_z_to_depth_ndc instead
fn view_z_to_depth_ndc(view_z: f32) -> f32 {
#ifdef VIEW_PROJECTION_PERSPECTIVE
return -perspective_camera_near() / view_z;
#else ifdef VIEW_PROJECTION_ORTHOGRAPHIC
return view_bindings::view.clip_from_view[3][2] + view_z * view_bindings::view.clip_from_view[2][2];
#else
let ndc_pos = view_bindings::view.clip_from_view * vec4(0.0, 0.0, view_z, 1.0);
return ndc_pos.z / ndc_pos.w;
#endif
return view::view_z_to_depth_ndc(view_z, view_bindings::view.clip_from_view);
}

/// DEPRECATED: use bevy_render::view::prev_view_z_to_depth_ndc instead
fn prev_view_z_to_depth_ndc(view_z: f32) -> f32 {
#ifdef VIEW_PROJECTION_PERSPECTIVE
return -perspective_camera_near() / view_z;
#else ifdef VIEW_PROJECTION_ORTHOGRAPHIC
return prepass_bindings::previous_view_uniforms.clip_from_view[3][2] +
view_z * prepass_bindings::previous_view_uniforms.clip_from_view[2][2];
#else
let ndc_pos = prepass_bindings::previous_view_uniforms.clip_from_view *
vec4(0.0, 0.0, view_z, 1.0);
return ndc_pos.z / ndc_pos.w;
#endif
return view::view_z_to_depth_ndc(view_z, prepass_bindings::previous_view_uniforms.clip_from_view);
}

// -----------------
// UV --------------
// -----------------

/// Convert ndc space xy coordinate [-1.0 .. 1.0] to uv [0.0 .. 1.0]
/// DEPRECATED: use bevy_render::view::ndc_to_uv instead
fn ndc_to_uv(ndc: vec2<f32>) -> vec2<f32> {
return ndc * vec2(0.5, -0.5) + vec2(0.5);
return view::ndc_to_uv(ndc);
}

/// Convert uv [0.0 .. 1.0] coordinate to ndc space xy [-1.0 .. 1.0]
/// DEPRECATED: use bevy_render::view::uv_to_ndc instead
fn uv_to_ndc(uv: vec2<f32>) -> vec2<f32> {
return uv * vec2(2.0, -2.0) + vec2(-1.0, 1.0);
return view::uv_to_ndc(uv);
}

/// returns the (0.0, 0.0) .. (1.0, 1.0) position within the viewport for the current render target
/// [0 .. render target viewport size] eg. [(0.0, 0.0) .. (1280.0, 720.0)] to [(0.0, 0.0) .. (1.0, 1.0)]
/// DEPRECATED: use bevy_render::view::frag_coord_to_uv instead
fn frag_coord_to_uv(frag_coord: vec2<f32>) -> vec2<f32> {
return (frag_coord - view_bindings::view.viewport.xy) / view_bindings::view.viewport.zw;
return view::frag_coord_to_uv(frag_coord, view_bindings::view.viewport);
}

/// Convert frag coord to ndc
/// DEPRECATED: use bevy_render::view::frag_coord_to_ndc instead
fn frag_coord_to_ndc(frag_coord: vec4<f32>) -> vec3<f32> {
return vec3(uv_to_ndc(frag_coord_to_uv(frag_coord.xy)), frag_coord.z);
return view::frag_coord_to_ndc(frag_coord, view_bindings::view.viewport);
}

/// Convert ndc space xy coordinate [-1.0 .. 1.0] to [0 .. render target
/// viewport size]
/// DEPRECATED: use bevy_render::view::ndc_to_frag_coord instead
fn ndc_to_frag_coord(ndc: vec2<f32>) -> vec2<f32> {
return ndc_to_uv(ndc) * view_bindings::view.viewport.zw;
return view::ndc_to_frag_coord(ndc, view_bindings::view.viewport);
}
Loading
Loading