Skip to content

Rename AnimationGraph#16280

Closed
BenjaminBrienen wants to merge 2 commits into
bevyengine:mainfrom
BenjaminBrienen:rename-animation-graph
Closed

Rename AnimationGraph#16280
BenjaminBrienen wants to merge 2 commits into
bevyengine:mainfrom
BenjaminBrienen:rename-animation-graph

Conversation

@BenjaminBrienen

@BenjaminBrienen BenjaminBrienen commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

Objective

Fixes #15604

Solution

Replace "AnimationGraph" with "BlendGraph". Rename "animatable" to "blendable" accordingly.

TODO: Update the comments. I see a lot of "// animation graph". I'll do this once this is blessed and the scope has been determined.

Testing

Simple refactor can be evaluated by CI

Migration Guide

I'll create this once this has been blessed.

@BenjaminBrienen

Copy link
Copy Markdown
Contributor Author

The scope of this task needs to be precisely defined. What other types should be renamed for clarity? Should the term "blend" be used in documentation as well?

@BenjaminBrienen BenjaminBrienen self-assigned this Nov 7, 2024
@BenjaminBrienen BenjaminBrienen added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Animation Make things move and change over time X-Needs-SME This type of work requires an SME to approve it. D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 7, 2024
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Nov 7, 2024
@hukasu

hukasu commented Dec 7, 2024

Copy link
Copy Markdown
Contributor

Shouldn't the name of the file also be renamed from animatable.rs to blendable.rs?

And what about the extension of the AnimationGraphAssetLoader from .animgraph to .blendgraph?

@BenjaminBrienen

Copy link
Copy Markdown
Contributor Author

Good ideas, thanks.

@BenjaminBrienen BenjaminBrienen added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 7, 2024
@alice-i-cecile alice-i-cecile added S-Waiting-on-SME This is currently waiting for an SME to resolve something controversial and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Dec 31, 2024

@pcwalton pcwalton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any problem with this.

@mweatherley mweatherley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but there are still a bunch of places in animatable.rs and animation_curves.rs where "animatable" should be changed to "blendable" (including the name of the former module, probably).

@alice-i-cecile alice-i-cecile removed this from the 0.16 milestone Mar 9, 2025
@alice-i-cecile alice-i-cecile added S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! X-Contentious There are nontrivial implications that should be thought through and removed X-Needs-SME This type of work requires an SME to approve it. S-Waiting-on-SME This is currently waiting for an SME to resolve something controversial labels Mar 9, 2025
@alice-i-cecile

Copy link
Copy Markdown
Member

Marking as Adopt-Me: I still think this is a good change (and there's support from animation experts), but there's more work to do here and a boatload of merge conflicts.

@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Animation Feb 12, 2026
@cart cart closed this May 5, 2026
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Animation May 5, 2026
@cart cart reopened this May 5, 2026
@github-project-automation github-project-automation Bot moved this from Done to Needs SME Triage in Animation May 5, 2026
@ChristopherBiscardi

Copy link
Copy Markdown
Contributor

adoption attempt in #22782 so closing this one

@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Animation May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Animation Make things move and change over time C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! X-Contentious There are nontrivial implications that should be thought through

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Rename AnimationGraph to something like BlendGraph or BlendTree

7 participants