example render_to_texture: remove extra light#13398
Merged
alice-i-cecile merged 1 commit intoMay 16, 2024
Merged
Conversation
mockersf
added
A-Rendering
rparrett
approved these changes
May 16, 2024
tychedelia
approved these changes
May 16, 2024
tychedelia
left a comment
tychedelia
left a comment
Member
There was a problem hiding this comment.
Thanks! Sorry for not cleaning this up correctly.
alice-i-cecile
added
the
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
render_to_texture, #12502 Remove limit on RenderLayers. #13317 changed the comment on the existing light saying lights don't work on multiple layers, then add a light on multiple layers explaining that it will work. it's confusingSolution
Testing
render_to_texture, lighting is correct