Skip to content

don't run update before window creation in winit#10741

Merged
cart merged 1 commit into
bevyengine:mainfrom
mockersf:dont-update-before-winit-window-creation
Nov 26, 2023
Merged

don't run update before window creation in winit#10741
cart merged 1 commit into
bevyengine:mainfrom
mockersf:dont-update-before-winit-window-creation

Conversation

@mockersf

@mockersf mockersf commented Nov 25, 2023

Copy link
Copy Markdown
Member

Objective

Solution

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Windowing Platform-agnostic interface layer to run your app in labels Nov 25, 2023
@mockersf mockersf added this to the 0.12.1 milestone Nov 25, 2023
@cart cart added this pull request to the merge queue Nov 26, 2023
Merged via the queue into bevyengine:main with commit 89d652b Nov 26, 2023
cart pushed a commit that referenced this pull request Nov 30, 2023
@mockersf @cart
don't run update before window creation in winit (#10741)
9cfc481 
# Objective

- Window size, scale and position are not correct on the first execution
of the systems
- Fixes #10407,  fixes #10642

## Solution

- Don't run `update` before we get a chance to create the window in
winit
- Finish reverting #9826 after #10389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cart cart cart approved these changes
@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior

Projects

None yet

Milestone

0.12.1

Development

Successfully merging this pull request may close these issues.

Incorrect window size obtained from WindowResolution in version 0.12 Text2D placement and size are wrong (window scale factor)

3 participants

@mockersf @cart @alice-i-cecile