Fix text2d not getting scale factor after window creation#10449
Closed
rparrett wants to merge 1 commit into
Closed
Fix text2d not getting scale factor after window creation#10449rparrett wants to merge 1 commit into
rparrett wants to merge 1 commit into
Conversation
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Nov 8, 2023
Contributor
Author
|
This fixes the issue for this example, but I believe the bug is more far-reaching than this. So this probably isn't the right solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #10407
Solution
This adds a local to keep track of the scale factor, which may or may not be a default value due to the lack of a window. Something similar is being done in
text_systemfor UI.I also explored using
window.is_added, but the scale factor doesn't seem to be available on the same frame where that is true.There may be some other more elegant solution -- I don't really understand #9826 where this broke.