Skip to content

Update color and naming for consistency#10367

Merged
cart merged 2 commits into
bevyengine:mainfrom
aevyrie:main
Nov 4, 2023
Merged

Update color and naming for consistency#10367
cart merged 2 commits into
bevyengine:mainfrom
aevyrie:main

Conversation

@aevyrie

@aevyrie aevyrie commented Nov 4, 2023

Copy link
Copy Markdown
Member

The ClearColor PR was merged before I was quite finished. This fixes a few errors, and addresses Cart's feedback about the pixel perfect example by updating the sprite colors to match the existing bevy bird branding colors.

image

@aevyrie aevyrie changed the title Update color and naming for consistency. Update color and naming for consistency Nov 4, 2023
@cart
cart enabled auto-merge November 4, 2023 01:59
@aevyrie

aevyrie commented Nov 4, 2023

Copy link
Copy Markdown
Member Author

02ce409 reverts the plane color change in #10339 to address some passive aggressive comments on discord.

image
image
image

@cart
cart disabled auto-merge November 4, 2023 01:59
@cart

cart commented Nov 4, 2023

Copy link
Copy Markdown
Member

Much appreciated!

@cart
cart enabled auto-merge November 4, 2023 02:01
@cart cart added this to the 0.12 milestone Nov 4, 2023

@alice-i-cecile alice-i-cecile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, thought you were done!

@aevyrie

aevyrie commented Nov 4, 2023

Copy link
Copy Markdown
Member Author

No worries, I didn't do a good job of communicating that. :)

@cart
cart added this pull request to the merge queue Nov 4, 2023
Merged via the queue into bevyengine:main with commit 1d8d78e Nov 4, 2023
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
The `ClearColor` PR was merged before I was quite finished. This fixes a
few errors, and addresses Cart's feedback about the pixel perfect
example by updating the sprite colors to match the existing bevy bird
branding colors.


![image](https://github.com/bevyengine/bevy/assets/2632925/33722c45-ed66-4d3a-af11-f4197611a13c)
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
The `ClearColor` PR was merged before I was quite finished. This fixes a
few errors, and addresses Cart's feedback about the pixel perfect
example by updating the sprite colors to match the existing bevy bird
branding colors.


![image](https://github.com/bevyengine/bevy/assets/2632925/33722c45-ed66-4d3a-af11-f4197611a13c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants