Fix unlit missing parameters#10144
Merged
Merged
Conversation
IceSentry
approved these changes
Oct 16, 2023
alice-i-cecile
added
C-Bug
robtfm
approved these changes
Oct 16, 2023
mockersf
approved these changes
Oct 16, 2023
mockersf
added
the
S-Ready-For-Final-Review
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
# Objective - The refactoring in bevyengine#10105 missed including the frag_coord and normal in pbr_input. ## Solution - Add them back
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - The refactoring in bevyengine#10105 missed including the frag_coord and normal in pbr_input. ## Solution - Add them back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution