ssao use unlit_color instead of white#10117
Merged
Merged
Conversation
robtfm
added
C-Bug
alice-i-cecile
approved these changes
Oct 14, 2023
Contributor
Author
|
this is separately fixed in #7820, this pr is in case that doesn't make it into 0.12 |
Contributor
|
@robtfm I'm unsure what the previous PR and this one is changing. Can you give me an overview of why base_color is no longer valid to pass? |
Contributor
Author
|
Base colour doesn’t get set until a few lines later |
Contributor
|
Also |
DGriffin91
approved these changes
Oct 14, 2023
JMS55
approved these changes
Oct 14, 2023
ameknite
pushed a commit
to ameknite/bevy
that referenced
this pull request
Nov 6, 2023
# Objective bevyengine#10105 changed the ssao input color from the material base color to white. i can't actually see a difference in the example but there should be one in some cases. ## Solution change it back.
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective bevyengine#10105 changed the ssao input color from the material base color to white. i can't actually see a difference in the example but there should be one in some cases. ## Solution change it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
#10105 changed the ssao input color from the material base color to white. i can't actually see a difference in the example but there should be one in some cases.
Solution
change it back.