chore: Renamed RenderInstance trait to ExtractInstance

[jancespivo]

Objective

Fixes [#10061]

Solution

Renamed RenderInstance to ExtractInstance, RenderInstances to ExtractedInstances and RenderInstancePlugin to ExtractInstancesPlugin

[github-actions]

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

[alice-i-cecile]

Is this a breaking change relative to Bevy 0.11?

[superdump]

@alice-i-cecile no. It's new API that was added to main recently. No 0.11 API was harmed in the making of this API. :)

@jancespivo - The Extractable naming doesn't feel right to me. The RenderInstance trait is implemented on the target type and can pull data from multiple main world components into that one type. I suggest we have a discussion to choose a name before making changes, just to save your time and effort. :)

[jancespivo]

Is this a breaking change relative to Bevy 0.11?

It shouldn't be. This is "only" renaming of types introduced in #10002

[jancespivo]

@jancespivo - The Extractable naming doesn't feel right to me. The RenderInstance trait is implemented on the target type and can pull data from multiple main world components into that one type. I suggest we have a discussion to choose a name before making changes, just to save your time and effort. :)

@superdump ok, sorry for rushing from my side. If it is more comfortable to have a discussion in the issue, let's move there. This is just quick and dirty renaming done in 2 minutes, so no problem for me. Feel free to close this PR :)

[pcwalton]

I don't have any opinion on the naming. Feel free to rename.

[alice-i-cecile]

struct Body;

impl ExtractInstance for Body {
    type Query = Read<ArHeadset>;
    type Filter = ();
    fn extract(item: QueryStuff) -> Self {}
}

pub struct ExtractedInstances<T>;

pub struct ExtractInstancePlugin;

FYI, this was the consensus naming on Discord.

[superdump]

Approving but please don't merge until #9258 is done to avoid creating conflicts in a big PR.