Rendering two 3d passes to the same window only shows the last pass when MSAA is enabled

[HackerFoo]

Bevy version

https://github.com/HackerFoo/bevy/tree/two_passes_main

Operating system & version

MacOS 12.1

What you did

This will show a red and a green cube spinning:

cargo run --example two_passes

Setting the MSAA samples to 4 will only show one cube.

[HackerFoo]

It looks like the clear pass is creating two separate attachments that are being fed through the two passes in parallel instead of combining them when using MSAA. This doesn't happen when MSAA is disabled.

From the Metal debugger:

[HackerFoo]

The bug seems to be in how the resolve textures are handled; the same texture should be used for both passes. Changing the test on this line to true gives the intended behavior: https://github.com/bevyengine/bevy/blob/main/crates/bevy_render/src/texture/texture_cache.rs#L44

[superdump]

@HackerFoo can this be closed since the camera-driven rendering PR was merged? I don't remember if it addressed MSAA or not.

[HackerFoo]

Does MSAA work with multiple passes on main?