Open
Conversation
Contributor
Author
|
I tested this on FX2D and it works there as well. I reviewed the code I've been running over the past week and I see I did use shapes with multiple contours but I must have been using P2D each time, until today. Anyhow, I'm glad I found the shortcoming in my PR before someone else did. Here's a real-world example with OpenStreetMap data employing the fix, adding a new drawing mode to the prettymaps library: Thank you for all of your hard work over the years on Processing! I use it every day. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix for #791.
Regrettably, when I tested the fix for #643 I didn't test shapes with multiple contours. This fix will increment the
codeIndexvariable so that the vertex codes from thevertexCodesarray stay in line with the vertices in theverticesarray.I should have thought to test with multiple contours when I made the previous PR #776 .
Here's a much more complex example using real-life data from OpenStreetMap:
There's a ton of contours in this shape it is drawn correctly.