fix #643 - PShape.beginContour() bug

[hx2A]

Fix for bug #643.

I tested this with the default JAVA2D and FX2D renderers in the PDE using the PShape.beginContour() example code as well as some code in the #643 thread. Happy to do more testing as needed.

[benfry]

Excellent, thanks for the fix.

If you'd be up for doing a PR for JavaFX as well, that would also be super helpful.

Thanks again.

[hx2A]

Excellent, thanks for the fix.

You are welcome! This is my first contribution to the Processing code.

If you'd be up for doing a PR for JavaFX as well, that would also be super helpful.

I am, but does this PR not fix the issue for FX2D as well? When I try to reproduce the bug in the PDE with FX2D and with my updated core.jar, I see the contour works correctly.

import processing.javafx.*;

PShape s;
void setup() {
  size(400, 200, FX2D);
  fill(255, 0, 0);
  noLoop();
}
void draw() {
  translate(50, 50);
  s = createShape();
  s.beginShape();
  s.fill(255, 0, 0);
  s.vertex(  0, 0);
  s.vertex(100, 0);
  s.vertex(100, 100);
  s.vertex(  0, 100);
  s.beginContour();
  s.vertex( 25, 25);
  s.vertex( 25, 75);
  s.vertex( 75, 75);
  s.vertex( 75, 25);
  s.endContour();
  s.endShape(CLOSE);
  shape(s, 0, 0);

  translate(200, 0);

  beginShape();
  fill(255, 0, 0);
  vertex( 0, 0);
  vertex(100, 0);
  vertex(100, 100);
  vertex(0, 100);
  beginContour();
  vertex(25, 25);
  vertex(25, 75);
  vertex(75, 75);
  vertex(75, 25);
  endContour();
  endShape(CLOSE);
}

The JavaFX renderer doesn't have a PShape class of its own, so doesn't it use the same PShape that the Java2D renderer uses?

[benfry]

Ah, I misunderstood what you'd written about it working with both Java2D and JavaFX. Yes, we should be set for JavaFX as well.

Thanks again!