docs(integrations): clarify Hermes monkeypatch by version - #1278
Merged
Conversation
Signed-off-by: Drew Cain <groksrc@gmail.com>
groksrc
changed the title
groksrc
marked this pull request as ready for review
August 19, 2026 01:55
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes_cli/plugins.pyWhy
Follow-up to #1274. That PR updated the compatibility table but the detailed instructions still unconditionally listed both Hermes files and included the obsolete collector replacement. A modern Hermes user following the full document could therefore undo the lifecycle ownership fix that #1274 preserves.
User impact
Users can now select the correct patch from their installed Hermes version without applying the legacy collector workaround to modern releases.
Validation
git diff --checkpassed