Skip to content

fix(integrations): preserve Hermes registration ownership - #1274

Open
mikemikimike wants to merge 1 commit into
basicmachines-co:mainfrom
mikemikimike:fix/1257-hermes-registration
Open

fix(integrations): preserve Hermes registration ownership#1274
mikemikimike wants to merge 1 commit into
basicmachines-co:mainfrom
mikemikimike:fix/1257-hermes-registration

Conversation

@mikemikimike

Copy link
Copy Markdown

Summary

  • avoid private PluginManager writes when Hermes provides command or skill registration APIs
  • retain capability-gated fallback support for legacy collectors
  • update the Hermes manifest and compatibility guidance for the lifecycle-aware collector

Testing

  • Python 3.14 focused: 107 passed
  • Python 3.12 Hermes suite: 269 passed, 12 skipped
  • Hermes manifest validation, Ruff lint and format checks, and git diff --check passed

Notes

  • just package-check-hermes could not run because just is not installed on this Windows environment; its underlying manifest and Python 3.12 unit-suite checks were run directly.
  • ty check integrations/hermes still reports existing external-Hermes import and strict-annotation diagnostics.

Fixes #1257

Signed-off-by: mikemikimike <13286568797@163.com>
@CLAassistant

CLAassistant commented Aug 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] integrations/hermes: stop overwriting modern provider registrations

2 participants