feat(sequencer)!: add ibc_sudo_address to genesis, only allow IbcRelay actions from this address#721
Merged
Merged
Conversation
joroshiba
approved these changes
Feb 2, 2024
joroshiba
left a comment
joroshiba
left a comment
Member
There was a problem hiding this comment.
I'm not seeing the change in state from sudo_key to sudo_address? Is that implemented somehwere, otherwise LGTM
noot
changed the title
ibc_sudo_address to genesis, only allow IbcRelay actions from this addressibc_sudo_address to genesis, only allow IbcRelay actions from this address
Contributor
Author
|
@joroshiba the state key doesn't need to be changed, it's unrelated to the name of the field in genesis, so this is fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as title says, make modifying IBC clients/connections/channels permissioned. this allows only a specific key (should be the key used by hermes) to send
IbcRelayactions.Background
we probably don't want IBC channels being arbitrarily opened at this time.
Changes
ibc_sudo_addressto genesisIbcRelayactions from this addressTesting
unit tests
Breaking Changelist
ibc_sudo_addressRelated Issues
Link any issues that are related, prefer full github links.
closes #720