Skip to content

Revert "Revert "Update 'salt' details for EncryptHeader AuthToken details (#6881)" (#6902)"#6922

Merged
sfc-gh-ahusain merged 1 commit into
apple:mainfrom
sfc-gh-ahusain:ahusain-header-salt-revert
Apr 22, 2022
Merged

Revert "Revert "Update 'salt' details for EncryptHeader AuthToken details (#6881)" (#6902)"#6922
sfc-gh-ahusain merged 1 commit into
apple:mainfrom
sfc-gh-ahusain:ahusain-header-salt-revert

Conversation

@sfc-gh-ahusain

Copy link
Copy Markdown
Collaborator

Description

Major changes proposed:

  1. This reverts commit f38b2e8.
  2. Also add fix for Valgrind failure due to unintialized variables.
  3. Improve checks to catch is cipherKey details cached in BlobCipherKeyCache
    isn't as expected

Testing

Overall correctness: 10K (20220421-193911-ahusain-foundationdb-a730e5cb38541e20)
EncyrptionOps correctness: 100K (20220421-194315-ahusain-foundationdb-29c598a8b9420430)
EncryptionOps Valgrind: 100 (20220421-194434-ahusain-foundationdb-7fc5f98eddc0921a)

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

…ails (apple#6881)" (apple#6902)"

Description

Major changes proposed:
1. This reverts commit f38b2e8.
2. Also add fix for Valgrind failure due to unintialized variables.
3. Improve checks to catch is cipherKey details cached in BlobCipherKeyCache
   isn't as expected

Testing

Overall correctness: 10K (20220421-193911-ahusain-foundationdb-a730e5cb38541e20)
EncyrptionOps correctness: 100K (20220421-194315-ahusain-foundationdb-29c598a8b9420430)
EncryptionOps Valgrind: 100 (20220421-194434-ahusain-foundationdb-7fc5f98eddc0921a)
@fdb-windows-ci

Copy link
Copy Markdown
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci

Copy link
Copy Markdown
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 658bd01
  • Result: FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 658bd01
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-ahusain sfc-gh-ahusain merged commit 04ecd8e into apple:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants