Revert "Update 'salt' details for EncryptHeader AuthToken details (#6…#6902
Merged
sfc-gh-ahusain merged 1 commit intoApr 21, 2022
Merged
Conversation
sfc-gh-mpilman
added
nightly correctness bugs
build cop
sfc-gh-ahusain
approved these changes
Apr 20, 2022
sfc-gh-ahusain
left a comment
sfc-gh-ahusain
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the revert; shall fix and reintroduce the change later.
Collaborator
|
I will take a look at the issue soon to see if it can be fixed. |
Contributor
AWS CodeBuild CI Report for Linux CentOS 7
|
Collaborator
Doxense CI Report for Windows 10
|
Collaborator
|
Sent #6908 to fix the valgrind error. |
sfc-gh-ahusain
added a commit
to sfc-gh-ahusain/foundationdb
that referenced
this pull request
Apr 21, 2022
…ails (apple#6881)" (apple#6902)" Description Major changes proposed: 1. This reverts commit f38b2e8. 2. Also add fix for Valgrind failure due to unintialized variables. 3. Improve checks to catch is cipherKey details cached in BlobCipherKeyCache isn't as expected Testing Overall correctness: 10K (20220421-193911-ahusain-foundationdb-a730e5cb38541e20) EncyrptionOps correctness: 100K (20220421-194315-ahusain-foundationdb-29c598a8b9420430) EncryptionOps Valgrind: 100 (20220421-194434-ahusain-foundationdb-7fc5f98eddc0921a)
sfc-gh-ahusain
added a commit
that referenced
this pull request
Apr 22, 2022
…ails (#6881)" (#6902)" (#6922) Description Major changes proposed: 1. This reverts commit f38b2e8. 2. Also add fix for Valgrind failure due to unintialized variables. 3. Improve checks to catch is cipherKey details cached in BlobCipherKeyCache isn't as expected Testing Overall correctness: 10K (20220421-193911-ahusain-foundationdb-a730e5cb38541e20) EncyrptionOps correctness: 100K (20220421-194315-ahusain-foundationdb-29c598a8b9420430) EncryptionOps Valgrind: 100 (20220421-194434-ahusain-foundationdb-7fc5f98eddc0921a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a38318a.
The above commit introduced a memory bug which causes many valgrind failures in the nightlies. This either needs to be fixed quickly or we should revert the change for now.
Code-Reviewer Section
The general guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branchormainif this is the youngest branch)