Repository navigation
fix(utils): check the whole MPEG and ADTS frame header before detecting audio - #298
Merged
Merged
Conversation
donghaoren
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #297.
detectAudioMimeTypetreats anything that starts with an 11-bit sync word as an MP3 or AAC frame. 0xFF padding (FF FF FF) and other binary data likeFF E1 00pass that check, so the viewer'svalueKindshows an audio player for them and never looks at the path's file extension.This uses the same header check the backend got in #297. ADTS needs the 12-bit sync word and a valid sampling frequency index. MPEG audio can't use the reserved version, layer, bitrate or sample rate values.
Testing:
packages/utils/test/media.test.jsfails on main and passes with the fix. All 124 utils tests pass.audio/mpegandaudio/aac.tsc --buildand Prettier are clean.