Repository navigation
fix(projection): detect MP3 and AAC frames without an ID3 tag as audio - #297
Merged
Merged
Conversation
Collaborator
|
Thanks! Could you add a few more non-audio tests like this: These should all return |
… audio 0xFF padding and other binary data can start with the same sync bits as an MPEG audio or ADTS frame. Also check the reserved version, layer, bitrate and sample rate values, and the full 12-bit ADTS sync word.
Contributor
Author
|
Thanks, added all four in f1083fc. Two of them (0xFF padding and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_detect_mime_typeonly treats bytes as MP3 when they start with an ID3 tag or exactlyFF FB, which is MPEG-1 Layer III without CRC. Many MP3s without an ID3 tag start differently: 16 to 24 kHz files (FF F3), 8 to 12 kHz files (FF E3) and files with CRC (FF FA). AAC in ADTS starts withFF F1. All of these fall through to the "image" default, so automatic modality detection treats audio columns as images.This uses the same check as the frontend's
detectAudioMimeTypeinpackages/utils/src/media.ts: the 11-bit sync word, then the layer bits to tell AAC from MPEG audio. JPEG is still checked first, soFF D8isn't affected.Testing:
tests/test_modality_detection.pyfail on main and pass with the fix (54 passed).ruff format --checkandruff checkare clean.