[TVMScript] Improve printer for TIR syntax sugar#9680
Merged
Conversation
added 2 commits
December 8, 2021 12:31
e47a560 to
0e0202e
Compare
vinx13
reviewed
Dec 8, 2021
vinx13
requested changes
Dec 9, 2021
vinx13
left a comment
Member
There was a problem hiding this comment.
Please fix CI error and double check if works locally
vinx13
requested changes
Dec 9, 2021
added 2 commits
December 9, 2021 00:00
vinx13
requested changes
Dec 9, 2021
vinx13
left a comment
Member
There was a problem hiding this comment.
from the CI error looks like there are some issues with reads/writes in previous PR
added 2 commits
December 9, 2021 17:37
vinx13
requested changes
Dec 10, 2021
vinx13
approved these changes
Dec 10, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This was referenced Jan 17, 2022
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to improve the printing of three kinds of syntax sugar introduced in TVMScript from #9492, #9620 and #9634. Examples below are supposedly the output of
print(some_tir_prim_func.script()).Before this PR
After this PR, note that brackets are removed
Before this PR
After this PR, note that all loops with 0 as min will be printed out as syntax sugar
Before this PR
After this PR, note that we assume T.match_buffer with two or less arguments specified are syntax-sugarred.
cc: @vinx13 @junrushao1994 @Hzfengsy