[bugfix] Fix the behavior of TVMScript printer#9974
Merged
Conversation
yzh119
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
MasterJH5574
approved these changes
Jan 19, 2022
MasterJH5574
left a comment
MasterJH5574
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the fix 😉
Member
|
Great fix, we have also discussed perhaps allow string "N, M, K" in the parameter side, perhaps we could have followup improvements to this |
vinx13
approved these changes
Jan 19, 2022
|
good catch @yzh119! Thanks for the fix |
yuanfz98
pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
crazydemo
pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fix to #9953 , it checks whether there are undefined variables in shapes and strides, if so, the buffer parameter is not a simple buffer.
cc @junrushao1994 @vinx13 @shingjan