[TIR] Add structural error printing for TensorIR#9306
Conversation
621db6c to
a656ba9
Compare
vinx13
left a comment
There was a problem hiding this comment.
Thanks for the PR. I left some comments
|
Hey thanks for the PR! It's a pretty nice POC, and I would like to deliberate on the format :-)
|
|
Hmm I just went through the code, We have plenty of these errors in with pytest.raises(tvm.tir.ScheduleError, ...):`
... |
|
Looks good to me. One thing I'm not sure is that will it compatible with the new block syntax. |
45aa4e9 to
f6da444
Compare
|
@shingjan you may need to update the test cases and code now that the new block syntax is introduced |
5191293 to
6e0e9c4
Compare
|
Printing nested loop is fixed as well as some comments addressed. Should be good for another good before we merge this in. @vinx13 @junrushao1994 |
ac89341 to
6388858
Compare
* add structural error printing * remove old code * address comments * address comments * add test * fix test case * fix nested loop * rm print * change simple loop cond * address comments * fix test * address comments * remove msg * add override * address comments * address comments
* add structural error printing * remove old code * address comments * address comments * add test * fix test case * fix nested loop * rm print * change simple loop cond * address comments * fix test * address comments * remove msg * add override * address comments * address comments
This PR intends to improve the error rendering by annotating regions of interest in TIR like synr following PR #8121.
Previously when there is an error:
With this PR, the error will be rendered like below:
cc: @vinx13 @junrushao1994