Skip to content

[TensorIR][M2a] Structural Error Reporting#8121

Merged
tqchen merged 1 commit into
apache:mainfrom
junrushao:feature/2021-05-24/structured-error-reporting
May 25, 2021
Merged

[TensorIR][M2a] Structural Error Reporting#8121
tqchen merged 1 commit into
apache:mainfrom
junrushao:feature/2021-05-24/structured-error-reporting

Conversation

@junrushao

Copy link
Copy Markdown
Member

This PR is part of the TensorIR upstreaming effort (#7527), stage M2a.

In this PR, we implemented ScheduleError, an error reporting mechanism for schedule primitives to report user-face error messages, with the functionality of rendering the TIR out in the TVM script syntax.

This set of APIs allows future improvement of error location rendering, e.g. more colorful rendering mechanisms like synr does.

@junrushao junrushao changed the title [TensorIR] Structural Error Reporting [TensorIR][M2a] Structural Error Reporting May 24, 2021
@junrushao

Copy link
Copy Markdown
Member Author

CC: @tqchen @jroesch @comaniac @icemelon9 @zhiics

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/tir/schedule/concrete_schedule.cc Outdated
Comment thread src/tir/schedule/concrete_schedule.cc Outdated
Comment thread src/tir/schedule/error.h Outdated
Comment thread src/tir/schedule/error.h Outdated
Comment thread src/tir/schedule/error.h Outdated
Comment thread src/tir/schedule/error.cc Outdated
Comment thread python/tvm/tir/schedule/schedule.py Outdated
Comment thread python/tvm/tir/schedule/schedule.py Outdated
Comment thread include/tvm/tir/schedule/schedule.h Outdated
Comment thread src/tir/schedule/concrete_schedule.cc Outdated
This PR is part of the TensorIR upstreaming effort (#7527), stage M2a.

In this PR, we implemented ScheduleError, an error reporting mechanism for schedule primitives to report user-face error messages, with the functionality of rendering the TIR out in the TVM script syntax.

This set of APIs allows future improvement of error location rendering, e.g. more colorful rendering mechanisms like synr does.

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
@tqchen tqchen merged commit 03c8a6f into apache:main May 25, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
This PR is part of the TensorIR upstreaming effort (apache#7527), stage M2a.

In this PR, we implemented ScheduleError, an error reporting mechanism for schedule primitives to report user-face error messages, with the functionality of rendering the TIR out in the TVM script syntax.

This set of APIs allows future improvement of error location rendering, e.g. more colorful rendering mechanisms like synr does.

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
This PR is part of the TensorIR upstreaming effort (apache#7527), stage M2a.

In this PR, we implemented ScheduleError, an error reporting mechanism for schedule primitives to report user-face error messages, with the functionality of rendering the TIR out in the TVM script syntax.

This set of APIs allows future improvement of error location rendering, e.g. more colorful rendering mechanisms like synr does.

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>

Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants