Skip to content

Revert "[ARITH] Fix InternalError: Check failed: (eval_vec_) is false" #18542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mshr-h merged 1 commit into from
Dec 4, 2025
Merged

Revert "[ARITH] Fix InternalError: Check failed: (eval_vec_) is false" #18542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/arith/int_set.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,10 +532,7 @@ class IntervalSetEvaluator : public ExprFunctor<IntervalSet(const PrimExpr&)> {
}

IntervalSet VisitExpr_(const BroadcastNode* op) final {
if (!eval_vec_) {
DLOG(WARNING) << "cannot evaluate set on expression " << ffi::GetRef<PrimExpr>(op);
return IntervalSet::Everything();
}
ICHECK(eval_vec_);

@gemini-code-assist gemini-code-assist Bot Dec 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change reverts #18536, restoring the ICHECK(eval_vec_). While this makes the behavior consistent with VisitExpr_(const RampNode* op), it may re-introduce the InternalError that the original PR aimed to fix. If the underlying issue causing this method to be called with eval_vec_ == false has been addressed elsewhere, then this revert is correct. Otherwise, we might see the same crash again.

return VisitExpr(op->value);
}

Expand Down
Loading