[ARITH] Fix InternalError: Check failed: (eval_vec_) is false#18536
Merged
Conversation
Member
|
would be good to dig into what is going on in the original case, since the old API states that |
Contributor
Author
|
Hi @tqchen Thanks for review comments and point out the crucial part and potential risk. I wasn't thinking straight to resolve the issue. Should we revert this change? |
Member
|
i think reverting for now is safer |
Member
|
@tqchen Thanks for pointing that. I'll send a pr to revert it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Commiters,
This PR is trying to fix issues #17936. Any suggestions would be appreciated if you are available.
Root Cause
Code paths that expected vector evaluation but encounter the scalar-only evaluation
eval_vec_ = falseSolution
BroadcastNodejust replicates the same scalar value and the evaluation might not requires special vector-aware handling