Rename IpEndpoint member functions named port() to network_order_port().

[ywkaras]

No description provided.

[bneradt]

Looks good. Thanks for doing this Walt.

[bneradt]

Looks like the CentOS build shows a few other uses of port():
https://jenkins.trafficserver.org/job/Github_Builds/job/centos/100/console

  CXX      QUICTypes.o
QUICTypes.cc: In constructor 'QUICFiveTuple::QUICFiveTuple(IpEndpoint, IpEndpoint, int)':
QUICTypes.cc:573:26: error: 'union IpEndpoint' has no member named 'port'
  573 |   this->_hash_code = src.port() + dst.port() + protocol;
      |                          ^~~~
QUICTypes.cc:573:39: error: 'union IpEndpoint' has no member named 'port'
  573 |   this->_hash_code = src.port() + dst.port() + protocol;
      |                                       ^~~~
QUICTypes.cc: In member function 'void QUICFiveTuple::update(IpEndpoint, IpEndpoint, int)':
QUICTypes.cc:583:26: error: 'union IpEndpoint' has no member named 'port'
  583 |   this->_hash_code = src.port() + dst.port() + protocol;
      |                          ^~~~
QUICTypes.cc:583:39: error: 'union IpEndpoint' has no member named 'port'
  583 |   this->_hash_code = src.port() + dst.port() + protocol;
      |                                       ^~~~
make[3]: *** [Makefile:1883: QUICTypes.o] Error 1

[SolidWallOfCode]

I'm not sure what the word "byte" is for in "network byte order". "Network order" necessarily means the order of the bytes.

[ywkaras]

OK eveybody, the next time @SolidWallOfCode says "network order", we hold him down and attach a parabolic antenna to his head. That'll learn him not to leave the "byte" out. https://www.aftership.com/brands/dish.com

[ywkaras]

@bneradt I made the changes you requested.

[bneradt]

Looks good to me.

[zwoop]

Cherry-picked to v9.2.x

[zwoop]

This has merge conflicts on 9.1.x, if we want this for the 9.1.x patch releases, we'd need a separate back port PR.

[ywkaras]

Thanks for trying, I'm not aware of any reason it can't wait till 9.2. If 9.1.x needs any commits that depend on this, let me know, I'll help.

…

On Mon, Nov 8, 2021 at 12:54 PM Leif Hedstrom ***@***.***> wrote: This has merge conflicts on 9.1.x, if we want this for the 9.1.x patch releases, we'd need a separate back port PR. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_trafficserver_pull_8421-23issuecomment-2D963473413&d=DwMCaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=bRwMsdu0uyXK0N-ngQ91KF2IzpTwU-AXjOlCZnyKc_4&m=An1W9HEbyGK6M24YOvzZ6OnfK_vQPH8Kkkz2pdN--Kk&s=FPkujyKfD5NWHBS-1J3shuUosf7m72kWzYlPmA-8kr8&e=>, or unsubscribe <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AG6ILQ7M7KGXJB7UEXW5DILULAMHFANCNFSM5F6NK77A&d=DwMCaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=bRwMsdu0uyXK0N-ngQ91KF2IzpTwU-AXjOlCZnyKc_4&m=An1W9HEbyGK6M24YOvzZ6OnfK_vQPH8Kkkz2pdN--Kk&s=0DJ09w84aFUtAPwA1n6Odt-UWuUeP2uWroX4r-YJ2gM&e=> . Triage notifications on the go with GitHub Mobile for iOS <https://urldefense.proofpoint.com/v2/url?u=https-3A__apps.apple.com_app_apple-2Dstore_id1477376905-3Fct-3Dnotification-2Demail-26mt-3D8-26pt-3D524675&d=DwMCaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=bRwMsdu0uyXK0N-ngQ91KF2IzpTwU-AXjOlCZnyKc_4&m=An1W9HEbyGK6M24YOvzZ6OnfK_vQPH8Kkkz2pdN--Kk&s=b4Cxy_E-TGB1xVCM7uRb0Y4-RHAko1JKWN-wtbC4f7k&e=> or Android <https://urldefense.proofpoint.com/v2/url?u=https-3A__play.google.com_store_apps_details-3Fid-3Dcom.github.android-26referrer-3Dutm-5Fcampaign-253Dnotification-2Demail-2526utm-5Fmedium-253Demail-2526utm-5Fsource-253Dgithub&d=DwMCaQ&c=sWW_bEwW_mLyN3Kx2v57Q8e-CRbmiT9yOhqES_g_wVY&r=bRwMsdu0uyXK0N-ngQ91KF2IzpTwU-AXjOlCZnyKc_4&m=An1W9HEbyGK6M24YOvzZ6OnfK_vQPH8Kkkz2pdN--Kk&s=IBLXYnq1XFLruMhi1E6lHOGO82TYOfVWjbpgfvvJVsY&e=>.